feat: Quest Journal Decorator Integration (Prompt Pair)#417
Open
Gerkinfeltser wants to merge 1 commit into
Open
feat: Quest Journal Decorator Integration (Prompt Pair)#417Gerkinfeltser wants to merge 1 commit into
Gerkinfeltser wants to merge 1 commit into
Conversation
MinLL
requested changes
May 29, 2026
| {% for jq in journal %}{% if jq.editorID == quest.editorID %} | ||
| {% if jq.journalText and not jq.isMisc %} | ||
| **{{ jq.questName }}** | ||
| {{ jq.journalText }} |
Owner
There was a problem hiding this comment.
Nice! Overall looks good. One thought; I think we're going to have duplicate journal objectives in some of our existing templates (player thoughts maybe?); Do a pass to ensure that this is the only source of quest info. Also - I don't have the game booted, but please
7a39df3 to
bcdd6cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with Gerkinfeltser/SkyrimNet#816 (quest journal decorator integration) — merge together for full functionality.
Problem
The existing quest decorators return raw engine data with unresolved tokens (
<Alias=...>,<Global=...>), making quest objectives unreadable in LLM prompts. A newget_quest_journal()decorator is being added to the main DLL that resolves these tokens and provides journal body text.Solution
Adds the
0610_party_quests.prompttemplate that usesget_quest_journal()to render resolved quest journal content in character bios.Changes
SKSE/Plugins/SkyrimNet/prompts/submodules/character_bio/0610_party_quests.prompt(new file, 42 lines)get_quest_journal()to get fully resolved quest dataget_selected_quests()withget_quest_journal()for tracked quests[DONE]markersshow_misc_tasksandshow_inactive_queststemplate variablesDependency
Requires the SkyrimNet DLL with the quest journal decorator registered (paired PR above). Without it,
get_quest_journal()returns an empty array and the template falls back to "No active quests currently tracked."Example Output