GEOPY-2618: GEOPY_2618 #339
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #339 +/- ##
========================================
Coverage 91.11% 91.11%
========================================
Files 117 117
Lines 6402 6402
Branches 777 777
========================================
Hits 5833 5833
Misses 379 379
Partials 190 190
🚀 New features to boost your workflow:
|
simpeg_drivers/options.py
Outdated
| """ | ||
|
|
||
| model_type: ModelTypeEnum = ModelTypeEnum.conductivity | ||
| model_type: ModelTypeEnum | None = ModelTypeEnum.conductivity |
There was a problem hiding this comment.
Unclear what would happen if the methods are EM or DC, with a model_type=None.
Can we update one of the tests to validate the outcome?
There was a problem hiding this comment.
I checked, and the only references to this model_type are checking if model_type == ModelTypeEnum.resistivity so we should be ok, but I'll add a check to one of the tests
There was a problem hiding this comment.
Hmm ok good. Glad it works. However, this is not reflecting the ui.json of EM-DC methods where the model_type is NOT optional - so can never be None here. Revert and change back the test. Turns out that the test_joint_surveys_conductivity_run already cover that case.
There was a problem hiding this comment.
I see your point. I removed the | None from general options classes and updated the tests.
There was a problem hiding this comment.
..except I added a model_type=None to the joint_surveys runtest because I didn't see how the test_joint_surveys_conductivity_run was testing this.
Co-authored-by: domfournier <dominiquef@mirageoscience.com>
…est to check that logic works with None
simpeg_drivers/options.py
Outdated
| """ | ||
|
|
||
| model_type: ModelTypeEnum = ModelTypeEnum.conductivity | ||
| model_type: ModelTypeEnum | None = ModelTypeEnum.conductivity |
There was a problem hiding this comment.
Hmm ok good. Glad it works. However, this is not reflecting the ui.json of EM-DC methods where the model_type is NOT optional - so can never be None here. Revert and change back the test. Turns out that the test_joint_surveys_conductivity_run already cover that case.
GEOPY-2618 - Conductivity/Resistivity switcher