Skip to content

feat(sdk): add Svelte adapter with writable store and SvelteKit example#191

Open
Muhammadcodes112 wants to merge 4 commits into
Miracle656:mainfrom
Muhammadcodes112:feat/sdk-svelte-adapter
Open

feat(sdk): add Svelte adapter with writable store and SvelteKit example#191
Muhammadcodes112 wants to merge 4 commits into
Miracle656:mainfrom
Muhammadcodes112:feat/sdk-svelte-adapter

Conversation

@Muhammadcodes112
Copy link
Copy Markdown

Summary

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Docs
  • Tests
  • CI / tooling

Component

  • Wallet frontend
  • SDK
  • Contracts
  • Agent

Checklist

  • I have read CONTRIBUTING.md
  • cargo test passes (contracts)
  • npm run typecheck passes (wallet / sdk / agent)
  • npm run build passes (wallet / agent)
  • I added or updated tests where relevant
  • I updated docs / README where relevant

Closes #174

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

Someone is attempting to deploy a commit to the miracle656's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 27, 2026

@Muhammadcodes112 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Copy link
Copy Markdown
Owner

@Miracle656 Miracle656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong work on the architectural refactor — extracting InvisibleWalletCore so framework-specific adapters can share the logic is the right pattern. Two blockers before merge:

1. Compiled output is committed (must remove)

The diff includes 12 generated files under sdk/svelte/dist/:

sdk/svelte/dist/src/InvisibleWalletCore.{d.ts,js}
sdk/svelte/dist/src/__tests__/useInvisibleWallet.test.{d.ts,js}
sdk/svelte/dist/src/index.{d.ts,js}
sdk/svelte/dist/src/useInvisibleWallet.{d.ts,js}
sdk/svelte/dist/src/utils.{d.ts,js}
sdk/svelte/dist/svelte/src/index.{d.ts,js}

These are TypeScript build artifacts and should never be in the repo.

Fix:

git rm -r --cached sdk/svelte/dist
echo "dist/" >> sdk/svelte/.gitignore
git add sdk/svelte/.gitignore
git commit -m "chore(sdk/svelte): gitignore dist build output"

2. Verify the React hook still works

The refactor moves ~1000 lines from useInvisibleWallet.ts into a new InvisibleWalletCore class. The React hook is in production at https://veil-ezry.vercel.app — any regression breaks the live wallet.

Please confirm by running:

cd sdk
npm install
npm test   # must pass — exercises the hook end-to-end with mocked SDK

…and paste the green output in a PR comment.

Once both are addressed I'll merge straight away. The Svelte adapter itself looks great.

@Muhammadcodes112
Copy link
Copy Markdown
Author

Strong work on the architectural refactor — extracting InvisibleWalletCore so framework-specific adapters can share the logic is the right pattern. Two blockers before merge:

1. Compiled output is committed (must remove)

The diff includes 12 generated files under sdk/svelte/dist/:

sdk/svelte/dist/src/InvisibleWalletCore.{d.ts,js}
sdk/svelte/dist/src/__tests__/useInvisibleWallet.test.{d.ts,js}
sdk/svelte/dist/src/index.{d.ts,js}
sdk/svelte/dist/src/useInvisibleWallet.{d.ts,js}
sdk/svelte/dist/src/utils.{d.ts,js}
sdk/svelte/dist/svelte/src/index.{d.ts,js}

These are TypeScript build artifacts and should never be in the repo.

Fix:

git rm -r --cached sdk/svelte/dist
echo "dist/" >> sdk/svelte/.gitignore
git add sdk/svelte/.gitignore
git commit -m "chore(sdk/svelte): gitignore dist build output"

2. Verify the React hook still works

The refactor moves ~1000 lines from useInvisibleWallet.ts into a new InvisibleWalletCore class. The React hook is in production at https://veil-ezry.vercel.app — any regression breaks the live wallet.

Please confirm by running:

cd sdk
npm install
npm test   # must pass — exercises the hook end-to-end with mocked SDK

…and paste the green output in a PR comment.

Once both are addressed I'll merge straight away. The Svelte adapter itself looks great.

Alright I'll do so right away

Muhammadcodes112 and others added 2 commits May 29, 2026 03:07
@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented May 29, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
33210559 Triggered Generic Password 03f3904 examples/nextjs/src/lib/network.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Muhammadcodes112
Copy link
Copy Markdown
Author

Changes implemented sir, Pls Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Svelte adapter for invisible-wallet-sdk

2 participants