feat(sdk): add Svelte adapter with writable store and SvelteKit example#191
feat(sdk): add Svelte adapter with writable store and SvelteKit example#191Muhammadcodes112 wants to merge 4 commits into
Conversation
|
Someone is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Muhammadcodes112 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Miracle656
left a comment
There was a problem hiding this comment.
Strong work on the architectural refactor — extracting InvisibleWalletCore so framework-specific adapters can share the logic is the right pattern. Two blockers before merge:
1. Compiled output is committed (must remove)
The diff includes 12 generated files under sdk/svelte/dist/:
sdk/svelte/dist/src/InvisibleWalletCore.{d.ts,js}
sdk/svelte/dist/src/__tests__/useInvisibleWallet.test.{d.ts,js}
sdk/svelte/dist/src/index.{d.ts,js}
sdk/svelte/dist/src/useInvisibleWallet.{d.ts,js}
sdk/svelte/dist/src/utils.{d.ts,js}
sdk/svelte/dist/svelte/src/index.{d.ts,js}
These are TypeScript build artifacts and should never be in the repo.
Fix:
git rm -r --cached sdk/svelte/dist
echo "dist/" >> sdk/svelte/.gitignore
git add sdk/svelte/.gitignore
git commit -m "chore(sdk/svelte): gitignore dist build output"2. Verify the React hook still works
The refactor moves ~1000 lines from useInvisibleWallet.ts into a new InvisibleWalletCore class. The React hook is in production at https://veil-ezry.vercel.app — any regression breaks the live wallet.
Please confirm by running:
cd sdk
npm install
npm test # must pass — exercises the hook end-to-end with mocked SDK…and paste the green output in a PR comment.
Once both are addressed I'll merge straight away. The Svelte adapter itself looks great.
Alright I'll do so right away |
Co-authored-by: Cursor <cursoragent@cursor.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 33210559 | Triggered | Generic Password | 03f3904 | examples/nextjs/src/lib/network.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Changes implemented sir, Pls Review |
Summary
Type of change
Component
Checklist
cargo testpasses (contracts)npm run typecheckpasses (wallet / sdk / agent)npm run buildpasses (wallet / agent)Closes #174