Upgrading Webview#11
Open
KaviHarjani wants to merge 3 commits into
Open
Conversation
… is resued after being paused to address the hanging issue + Added title bar with dark mode support (to have some differentiation) + removed drag-to-refresh because it was causing issues, have a refresh button on the app bar
Comment on lines
+51
to
+57
| debugPrint(''' | ||
| Page resource error: | ||
| code: ${error.errorCode} | ||
| description: ${error.description} | ||
| errorType: ${error.errorType} | ||
| isForMainFrame: ${error.isForMainFrame} | ||
| '''); |
Contributor
There was a problem hiding this comment.
Is it ok to leave this here?
Comment on lines
+84
to
+87
| "if(document.querySelectorAll('.top-nav-holder')){" | ||
| "const topNavHolders = document.querySelectorAll('.top-nav-holder');" | ||
| "for (let i = 0; i < topNavHolders.length; i++) {" | ||
| " topNavHolders[i].style.display = 'none';}}"); |
Contributor
There was a problem hiding this comment.
For a second two headers are seen before this hides one. One in the app bar and one of the top of the page.
Also, this repeated section can be moved to a common function if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading webview to the latest version + adding refresh when the app is resumed after being paused to address the hanging issue + Added title bar with dark mode support (to have some differentiation from website and app as google has asked for it) + removed drag-to-refresh because it was causing issues , have a refresh button on the app bar
@manujagobind could you check this out will have an apk for all to try out as well, and if want more details on the issue, it's there on basecamp