Add suppress_code_coverage flag for builds#3285
Merged
brentleyjones merged 4 commits intoMobileNativeFoundation:mainfrom Mar 6, 2026
Merged
Add suppress_code_coverage flag for builds#3285brentleyjones merged 4 commits intoMobileNativeFoundation:mainfrom
suppress_code_coverage flag for builds#3285brentleyjones merged 4 commits intoMobileNativeFoundation:mainfrom
Conversation
sebastianv1
force-pushed
the
sebastianv1/suppress-coverage-flag
branch
3 times, most recently
from
423b01e to
fbd55e5
Compare
aaronsky
approved these changes
Mar 6, 2026
tools/generators/pbxproj_prefix/src/Generator/Environment.swift
Outdated
Show resolved
Hide resolved
Signed-off-by: sebastian.shanus <sebastian.shanus@robinhood.com>
sebastianv1
force-pushed
the
sebastianv1/suppress-coverage-flag
branch
from
fbd55e5 to
3cc18d7
Compare
Signed-off-by: sebastian.shanus <sebastian.shanus@robinhood.com>
sebastianv1
force-pushed
the
sebastianv1/suppress-coverage-flag
branch
2 times, most recently
from
85a5e27 to
2fa4d51
Compare
Signed-off-by: sebastian.shanus <sebastian.shanus@robinhood.com>
sebastianv1
force-pushed
the
sebastianv1/suppress-coverage-flag
branch
from
2fa4d51 to
d45ccac
Compare
brentleyjones
approved these changes
Mar 6, 2026
Contributor
|
Please also add a |
Signed-off-by: sebastian.shanus <sebastian.shanus@robinhood.com>
brentleyjones
merged commit 49d8311
into
MobileNativeFoundation:main
7 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a build flag options to bypass the supported Xcode coverage builds with
rules_xcodeproj. We would find this flag useful for 2 reasons:This just adds an opt-out flag in addition to the configured build setting so that we can choose whether or not the project should use the built-in coverage solution.
This can be enabled by adding
--@rules_xcodeproj//xcodeproj:suppress_coverage_buildto your builds.