Conversation
- `PredicateBlockItem` → `OperatorBlockItem` - All `PredicateBarrierBlock` use `OperatorBlockItem`
sylv256
commented
May 8, 2025
sylv256
commented
May 8, 2025
ChrysanthCow
requested changes
May 14, 2025
Member
ChrysanthCow
left a comment
ChrysanthCow
left a comment
There was a problem hiding this comment.
Looks very good. While a bit cursed, the refactors make total sense to me.
I've mainly suggested a change caused by my old multiloader shenanigan code, to help avoid issues in the future with other mods integrating with us.
| conditionTemplate("creative_only") | ||
| ); | ||
|
|
||
| public static void registerAll() { |
Member
There was a problem hiding this comment.
Moreso an issue caused by my own code and not knowing you could do this, but we could move the actual registration away from registerAll(), and instead have it ran in the block/item fields. Which would help with race conditions on Fabric.
Like this:
public static final PredicateButtonBlock CREATIVE_ONLY_BUTTON = register("creative_only_button", new PredicateButtonBlock(
buttonProps(),
Barricade.asResource("barricade/icon/iron_sword"),
conditionTemplate("creative_only")
));| barrierProps() | ||
| ); | ||
|
|
||
| public static void registerAll() { |
Member
There was a problem hiding this comment.
See comment on block registration code.
common/src/main/java/net/modgarden/barricade/block/PredicateLeverBlock.java
Show resolved
Hide resolved
Member
Author
|
Whenever I come back to this I'm going to minimize the jank by removing the self-mixin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the codebase to use the new
PredicateBlocksystem and adds two new blocks: the Creative-Only Lever and the Creative-Only Button. It also does a few quality of life things such as enabling Enhanced Class Redefinition (DCEVM is now required) and using helper methods in registration classes.