-
Notifications
You must be signed in to change notification settings - Fork 130
Impl of apply_rotary_emb_qwen_naive and apply_wan_rope_with_torch_naive #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
Summary of ChangesHello @yeahdongcn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates new 'naive' PyTorch implementations for Rotary Positional Embeddings (RoPE) into the Qwen-image and WAN models. This provides an alternative, potentially more straightforward or debuggable, method for applying positional embeddings, which can be activated through a configuration setting. The changes include adding the new RoPE functions and updating the model's initialization logic to dynamically select the desired RoPE implementation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces naive PyTorch implementations for rotary position embeddings (apply_rotary_emb_qwen_naive and apply_wan_rope_with_torch_naive) and integrates them into the model configuration. The changes also include refactoring the selection logic for RoPE functions, which is a good improvement.
My review has identified a few areas for improvement:
- A potentially risky change in
.gitignorethat could lead to large files being committed. - Code duplication in both of the new naive RoPE implementations. I've suggested refactoring them to improve maintainability.
Overall, the core logic seems correct, and the changes make the RoPE implementation selectable, which is a great feature.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
This PR adds
apply_rotary_emb_qwen_naivefor qwen-image andapply_wan_rope_with_torch_naivefor wan. One can userope_type=torch_naiveto select it.Testing Done