Skip to content

Conversation

@yeahdongcn
Copy link
Contributor

This PR renames the qwen-image RoPE function to apply_qwen_rope_with_xxx to align with the naming conventions used by RoPE functions in other models, improving consistency and readability across the codebase.

Testing Done

root@worker3218:/ws/scripts/platforms/mthreads_musa# ./qwen_image_i2i_2511.sh

Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yeahdongcn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code consistency and readability by standardizing the naming of Rotary Positional Embedding (RoPE) functions specifically for the qwen-image model. The changes involve renaming functions to follow a apply_qwen_rope_with_xxx pattern and updating all references to these functions across relevant files to ensure proper integration and maintain a uniform codebase.

Highlights

  • Function Renaming for Consistency: Renamed Rotary Positional Embedding (RoPE) functions within the qwen-image model to apply_qwen_rope_with_xxx to align with established naming conventions, enhancing code readability and maintainability.
  • Import and Usage Updates: Updated import statements and dictionary lookups in transformer_infer.py for the qwen-image model to reflect the new function names, ensuring correct usage of the renamed RoPE functions.
  • Minor Reordering in WAN Model: Reordered entries in the rope_funcs dictionary within the wan model's transformer_infer.py for consistency, without changing function names or behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively improves code consistency by renaming the RoPE functions in the qwen-image model to align with the conventions used in other models. The changes are clear and contribute to better readability and maintainability. I've added one suggestion to further reduce code duplication.



def apply_wan_rope_with_flashinfer(
def apply_qwen_rope_with_flashinfer(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While renaming this function improves consistency, I noticed that its implementation is identical to apply_wan_rope_with_flashinfer in lightx2v/models/networks/wan/infer/utils.py. To improve maintainability and reduce code duplication, consider refactoring this into a single, generic function (e.g., apply_rope_with_flashinfer) and placing it in a shared utility module, such as under lightx2v/common/. Both qwen_image and wan models could then import and use this common function.

@helloyongyang helloyongyang merged commit 7ea50da into ModelTC:main Dec 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants