Conversation
Collaborator
Author
|
TODO: #3 에서 명시된 바와 같이 |
…ommit for ALL branches
Collaborator
Author
|
superseded by #5. Closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
/auth/validateendpoint 신설userService.verify()를 통해 해당 이메일 계정의 인증을 진행합니다./auth/signup및/auth/validate에 대한 Rate Limit 조치가 추후 필요합니다./auth/signup을 통해 발급된 인증코드에 대한 유효기간 제한이 없습니다. 추후 제한 시간을 검토해야 합니다.passwordfield 에plain-text password대신 SpringSecurity 에서 제공하는PasswordEncoder를 이용하여bcrypt와 같은 안전한 단방향 해시 기법을 이용해 비밀번호(의 대조군)을 저장합니다.docker빌드 파이프라인에서application.yaml대신application.docker.yaml을 사용하도록 GitHub Actions 스크립트를 조정합니다.JavaMail을 사용하여 메일을 발송용 서비스MailService를 구현합니다unideal.mailer.from이 신설되었습니다.Controller를RestController로 마이그레이션 합니다.AuthPageController에 해당 변경점을 백업합니다.