[202_2723]: Add toolbar entries for overbrace, underbrace and underline#2862
Open
dorodb-web22 wants to merge 1 commit intoMoganLab:mainfrom
Open
[202_2723]: Add toolbar entries for overbrace, underbrace and underline#2862dorodb-web22 wants to merge 1 commit intoMoganLab:mainfrom
dorodb-web22 wants to merge 1 commit intoMoganLab:mainfrom
Conversation
Contributor
|
The font for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2723
What
Added 3 missing entries to the wide accent toolbar popup in math mode:
\overbrace(make-wide)\underbrace(make-wide-under)\underline/ wide-bar (make-wide-under)Also added the corresponding 16x16 XPM icons using the same 8-color palette
as the existing accent icons (e.g. tm_bar.xpm).
Changed Files
Known Issue
I used the EXACT SAME COLOR PALETTE and
apixel art as the existing icons for the 3 new XPM icons ,but they render slightly differently at small sizes
(the
aappears as a blue dot instead of a clear letter).I wasn't able to figure out why ... the pixel data is byte-for-byte identical to the
working icons. Happy to take suggestions on improving the icons.
Testing
xmake build stem, ran withxmake run stem