[202_106] display the shortcut keys corresponding to the symbols in the right footer#2892
Open
Prthmsh7 wants to merge 3 commits intoMoganLab:mainfrom
Open
[202_106] display the shortcut keys corresponding to the symbols in the right footer#2892Prthmsh7 wants to merge 3 commits intoMoganLab:mainfrom
Prthmsh7 wants to merge 3 commits intoMoganLab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for #2886
Before :

After :

Root cause: The footer had no mechanism to look up or display keyboard shortcuts
Fix: Added
get_shortcut_suffix()which calls Scheme's kbd-find-inv-binding to resolve the shortcut for symbols, and used the existing kbd_shortcut() for operations which appends the result as [Shortcut] in the right footer.How to Test