Simplify and modernize the Docker build process for MonaServer2.#3
Open
WerWebWer wants to merge 1 commit intoMonaSolutions:masterfrom
Open
Simplify and modernize the Docker build process for MonaServer2.#3WerWebWer wants to merge 1 commit intoMonaSolutions:masterfrom
WerWebWer wants to merge 1 commit intoMonaSolutions:masterfrom
Conversation
Key changes: - Use Alpine packages for LuaJIT instead of building LuaJIT from source - Add optional SRT support controlled via the ENABLE_SRT build argument - Install runtime dependencies (luajit, libsrt) via apk - Add build dependencies (openssl-dev, luajit-dev, libsrt-dev) to the build stage - Replace multiple component builds with a single `make ENABLE_SRT=$ENABLE_SRT` - Replace `cp` with `install` for safer file installation - Reduce Dockerfile complexity and improve build reproducibility - Expose SRT port (9710/udp) - Document build options in README This change simplifies the Dockerfile, reduces build complexity, and allowsoptional SRT support without requiring manual modifications to the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key changes:
make ENABLE_SRT=$ENABLE_SRTcpwithinstallfor safer file installationThis change simplifies the Dockerfile, reduces build complexity, and allowsoptional SRT support without requiring manual modifications to the build.