Skip to content

Scene: Implement sceneObjCreator skeleton#920

Merged
MonsterDruide1 merged 1 commit into
MonsterDruide1:masterfrom
german77:sceneObjCreator
Feb 25, 2026
Merged

Scene: Implement sceneObjCreator skeleton#920
MonsterDruide1 merged 1 commit into
MonsterDruide1:masterfrom
german77:sceneObjCreator

Conversation

@german77
Copy link
Copy Markdown
Contributor

@german77 german77 commented Feb 20, 2026

After reviewing #911 I noticed this function didn't had a body. The implementation is quite simple but we are missing a bunch of headers. Nothing prevents us from creating the basic function structure.


This change is Reviewable


Report for 1.0 (ae76c74 - edcb7b2)

No changes

@github-actions github-actions Bot added the status:waiting for review This PR is ready to take the first or another look at it! label Feb 20, 2026
Copy link
Copy Markdown
Owner

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on german77).

@MonsterDruide1 MonsterDruide1 changed the title Scene: Make sceneObjCreator skeleton Scene: Implement sceneObjCreator skeleton Feb 24, 2026
@github-actions github-actions Bot added status:approved This PR is fully reviewed, it will now soak for a while (at most 24h) before being merged. status:ready to merge This PR is fully reviewed and the usual slack time has expired, so it can now be merged at any time. and removed status:waiting for review This PR is ready to take the first or another look at it! status:approved This PR is fully reviewed, it will now soak for a while (at most 24h) before being merged. labels Feb 24, 2026
@MonsterDruide1 MonsterDruide1 merged commit 4564f1b into MonsterDruide1:master Feb 25, 2026
11 checks passed
@german77 german77 deleted the sceneObjCreator branch February 25, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:ready to merge This PR is fully reviewed and the usual slack time has expired, so it can now be merged at any time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants