Conversation
added social icons to home page and footer. added images to home page (we can change so different from About page). Adjusted some spacing.
changed from images to fonts
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 96.49% 96.65% +0.16%
==========================================
Files 50 49 -1
Lines 399 389 -10
==========================================
- Hits 385 376 -9
+ Misses 14 13 -1
Continue to review full report at Codecov.
|
| font-weight: bold; | ||
| letter-spacing: 2px; | ||
| text-shadow: 2px 2px 4px #000000; | ||
| padding-right: $xxl-space; |
There was a problem hiding this comment.
Property padding-right already defined on line 139
| } | ||
| } | ||
|
|
||
| .photos { |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 4 spaces
| padding-bottom: $xxxl-space; | ||
| padding-left: $med-space; | ||
| padding-right: xxl-space; | ||
| padding-top: $med-space; |
| #social_side_links { | ||
|
|
||
| #social_side_links | ||
| { |
There was a problem hiding this comment.
Opening curly brace { should be preceded by one space
| @include on($medium-screen) { | ||
| #social_side_links { | ||
|
|
||
| #social_side_links |
There was a problem hiding this comment.
Avoid using id selectors
Selector social_side_links should be written in lowercase with hyphens
Line contains trailing whitespace
| padding-bottom: 60px; | ||
| } | ||
|
|
||
| /* social icons */ |
| line-height: $base-line-height; | ||
| padding-bottom: 60px; | ||
| line-height: $base-line-height; | ||
| padding-bottom: 60px; |
There was a problem hiding this comment.
Line should be indented 4 spaces, but was indented 2 spaces
| p { | ||
| line-height: $base-line-height; | ||
| padding-bottom: 60px; | ||
| line-height: $base-line-height; |
There was a problem hiding this comment.
Line should be indented 4 spaces, but was indented 2 spaces
|
|
||
| .social_icons { | ||
| padding-top: 15px; | ||
| padding-top: 20px; |
There was a problem hiding this comment.
Properties should be ordered font-size, letter-spacing, padding-top
| font-style: normal; | ||
| } | ||
|
|
||
| .linkedin::before { |
There was a problem hiding this comment.
Merge rule .linkedin::before with rule on line 44
4 participants
update to homepage image