Fix PROVIDER_URL not being read from e2e/.env#28
Merged
Conversation
up.sh now writes contract IDs, provider URL, and keys to e2e/.env so the E2E test works without knowing the provider-platform repo path. This fixes E2E on machines using non-default repo locations (BASE_DIR). Also fixed SAC deploy failing under set -e when the contract already exists on a persistent Stellar network.
providerUrl was only checked from Deno.env (process env), not from the merged env map. The PROVIDER_URL written by up.sh to e2e/.env was silently ignored, falling back to port 3000.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
providerUrlinconfig.tswas only read from process env vars, not from the.envfile mapPROVIDER_URLwritten byup.shtoe2e/.envwas silently ignored, falling back to port 3000Test plan
cd e2e && deno task e2e— should connect to port 3010, not 3000