fix: wait for friendbot readiness before funding accounts#31
Merged
Conversation
Allows running multiple stacks in parallel by overriding ports and names. All values default to the current hardcoded values for backwards compatibility.
up.sh checks Stellar RPC health before proceeding to account creation, but Friendbot takes a few extra seconds to initialize after RPC is healthy. This causes intermittent HTTP 502 errors when funding accounts. Adds an explicit Friendbot readiness loop (up to 30s) between the Stellar RPC check and the accounts stage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
./down.sh && ./up.sh— accounts fund successfully on first trycd e2e && deno task e2e) — passed in 44s