fix: remove hardcoded Grafana Cloud Tempo credentials#34
Merged
Conversation
The Tempo URL and auth token were hardcoded as fallback defaults, leaking production credentials into the repo. Both are now required via environment variables with clear error messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
😢 🙈
Summary
testnet/verify-otel.tsTEMPO_URLandTEMPO_AUTHare now required env vars (script exits with clear error if missing)Context
The previous code had production Grafana Cloud credentials as fallback defaults, meaning they were committed to the repo in plaintext. This was introduced in #32 as part of a large commit (53 files).
Test plan
deno run --allow-all testnet/verify-otel.tswithout env vars — should exit with errorTEMPO_URLandTEMPO_AUTHset — should work as before