fix: type errors and security hardening#57
Merged
Conversation
dashboard-auth.ts uses Buffer for signature decoding and nonce handling but was missing the import, causing 10 type errors.
findById and delete override base class signatures with incompatible composite key parameters. Rename to findByCompositeId and deleteByCompositeId to avoid the override conflict. No callers used the old names.
session.userId does not exist on the entity — the column is session.accountId. Fixes 1 type error.
Ownership checks in escrow summary and KYC GET now explicitly match sep10/undefined session types and reject unknown types, instead of relying on an implicit else branch that would silently accept any future token type.
Suspended accounts now return 401 "Invalid credentials" instead of 403 "Account suspended" to avoid confirming the password is correct. The suspension is logged at warn level for operational visibility.
Validate description is a string before calling slice. Use the truncate helper consistently for all logged fields.
AquiGorka
force-pushed
the
fix/moonlight-pay-review-fixes
branch
from
fcf93d0 to
f0fa7b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
deno check src/main.ts— 0 errors (was 15)