-
Notifications
You must be signed in to change notification settings - Fork 354
fix(web): clarify archive is irreversible by relabeling as Delete #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@moonshot-ai/kimi-code": patch | ||
| --- | ||
|
|
||
| Clarify that session archive is irreversible by relabeling as Delete. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,13 +5,16 @@ export default { | |
| newChat: 'New Chat', | ||
| newWorkspace: 'New Workspace', | ||
| emptyState: 'No sessions yet · click New Session to start', | ||
| archiveConfirm: 'Archive session?', | ||
| archiveConfirm: 'Permanently delete this session? This action cannot be undone.', | ||
| confirm: 'Confirm', | ||
| cancel: 'Cancel', | ||
| options: 'Options', | ||
| rename: 'Rename', | ||
| copyPath: 'Copy path', | ||
| archive: 'Archive', | ||
| copySessionId: 'Copy session ID ⧉', | ||
| copied: 'Copied ✓', | ||
| copyFailed: 'Copy failed', | ||
| archive: 'Delete', | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This updates the sidebar label to Delete, but the same destructive handler is still reachable from the active session header: Useful? React with 👍 / 👎. |
||
| fork: 'Fork session', | ||
| delete: 'Delete', | ||
| removeWorkspace: 'Remove workspace', | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,13 +5,16 @@ export default { | |
| newChat: '新建对话', | ||
| newWorkspace: '新建工作区', | ||
| emptyState: '还没有会话 · 点击 新建会话 开始', | ||
| archiveConfirm: '归档会话?', | ||
| archiveConfirm: '删除会话?', | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The English confirmation now says the session is permanently deleted and cannot be undone, but the Chinese locale only says “删除会话?”. In the Chinese UI this irreversible action is still confirmed as a generic delete without the no-recovery warning, so the two locales are no longer semantically in sync for the destructive confirmation. Useful? React with 👍 / 👎. |
||
| confirm: '确认', | ||
| cancel: '取消', | ||
| options: '选项', | ||
| rename: '重命名', | ||
| copyPath: '复制路径', | ||
| archive: '归档', | ||
| copySessionId: '复制 Session ID ⧉', | ||
| copied: '已复制 ✓', | ||
| copyFailed: '复制失败', | ||
| archive: '删除', | ||
| fork: '分叉会话', | ||
| delete: '删除', | ||
| removeWorkspace: '移除工作区', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the desktop session row,
sidebar.archiveConfirmis rendered in.archive-labeland that label is constrained to one line withoverflow: hidden/text-overflow: ellipsis(SessionRow.vuelines 143-146 and 406-414). With the confirm/cancel buttons present, this longer sentence is truncated in the sidebar, so the important “cannot be undone” warning is not visible before users confirm the irreversible action. Use shorter copy that fits or change the confirmation UI to show the full warning.Useful? React with 👍 / 👎.