feat: Add JWT Authentication#12
Open
3ettilina wants to merge 5 commits into
Open
Conversation
mtwichel
reviewed
Mar 23, 2024
mtwichel
left a comment
mtwichel
left a comment
Contributor
There was a problem hiding this comment.
Two little nitpicks - nice work! Thanks for doing this!
| import 'package:equatable/equatable.dart'; | ||
|
|
||
| /// Holds properties for generating a Doordash Drive API token | ||
| class AccessKey extends Equatable { |
Contributor
There was a problem hiding this comment.
Suggested change
| class AccessKey extends Equatable { | |
| class TokenProperties extends Equatable { |
I think when I hear access key, I think of a single key I need to make API calls. Could we rename this to be a bit more clear?
Contributor
Author
There was a problem hiding this comment.
I agree with you. When using AccessKey I was following Doordash Drive's doc suggestion. Will apply the change
| late String _token; | ||
| final AccessKey _accessKey; | ||
|
|
||
| String get getToken { |
Contributor
There was a problem hiding this comment.
Suggested change
| String get getToken { | |
| String get token { |
since this is already a getter, can we rename this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
This PR adds missing functionality for authenticating with DoorDashDrive based on an
AccessKeyprovided.It includes a little bit of refactor to make it work and isolate how we handle and store the generated token.
Type of Change