Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This PR adds support for the Battery Usermod in WLED.
It updates the Info model to parse the "u" key, handling the array-wrapped values for battery level and voltage.
A new DeviceBatteryView is added to display the battery status with SF Symbols.
The view is integrated into the device list row, appearing only when battery data is available.
Unit tests are included to verify the JSON decoding logic.


PR created automatically by Jules for task 6432345837442728410 started by @Moustachauve

- Update data model to parse UserMods ("u") and "Battery level"
- Create DeviceBatteryView to display battery icon and percentage
- Integrate battery view into DeviceInfoTwoRows
- Add unit tests for UserMods decoding
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- Update data model to parse UserMods ("u") and "Battery level"
- Create DeviceBatteryView to display battery icon and percentage
- Integrate battery view into DeviceInfoTwoRows
- Add unit tests for UserMods decoding
- Remove stale comment in Info.swift
- Update data model to parse UserMods ("u") and "Battery level"
- Create DeviceBatteryView to display battery icon and percentage
- Integrate battery view into DeviceInfoTwoRows
- Add unit tests for UserMods decoding
- Remove stale comment in Info.swift
- Update PreviewData to show battery in online device preview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant