fix(wip): declare exports as separate variables#59
Open
majordwarf wants to merge 1 commit intomasterfrom
Open
Conversation
jdrueckert
reviewed
Mar 6, 2022
Member
jdrueckert
left a comment
jdrueckert
left a comment
There was a problem hiding this comment.
For some reason, I wrote comments but then forgot to actually send them 🤦♀️
So here go a bunch of nitpick suggestions, and at least one actual question
| <Route | ||
| // pathId - URL param for directly accessing particular path. | ||
| path='/:pathId?' | ||
| path='/:pathId? ' |
Member
There was a problem hiding this comment.
what do we need the space here for?
| @@ -1,22 +1,23 @@ | |||
| import ContributionResources from "."; | |||
| // import index from "./index"; | |||
Member
There was a problem hiding this comment.
is this still required? if not can we remove it?
| }, | ||
| }; | ||
|
|
||
| export default Convention; No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| export default Convention; | |
| export default Convention; | |
| }, | ||
| }; | ||
|
|
||
| export default Git; No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| export default Git; | |
| export default Git; | |
Comment on lines
+13
to
+16
| // { | ||
| // name: 'Done. What else should I know about?', | ||
| // child: index, | ||
| // }, |
| }, | ||
| }; | ||
|
|
||
| export default index; No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| export default index; | |
| export default index; | |
| }, | ||
| }; | ||
|
|
||
| export default Contact; No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| export default Contact; | |
| export default Contact; | |
| }, | ||
| }; | ||
|
|
||
| export default Contributor; No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| export default Contributor; | |
| export default Contributor; | |
| }, | ||
| }; | ||
|
|
||
| export default index; No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| export default index; | |
| export default index; | |
| }, | ||
| }; | ||
|
|
||
| export default Architechture; No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| export default Architechture; | |
| export default Architechture; | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.