feat: add Rust-backed discrete convolution for random variables#40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds discrete convolution support to the Rust random variable algebra layer and connects it to the Python API.
The Rust changes introduce a
convolution_discreteimplementation that converts inputs to PDFs, computes pairwise support sums and probabilities, sorts the result, and merges duplicate support values into avalid discrete PDF.
RandomVariablenow supportsAddandAddAssign, and the new convolution operation is exported through the Python bindings.On the Python side, discrete calls to
applpy.algebra.convolutionnow delegate to the Rust-backedFastRVpath instead of performing the full computation in Python. This preserves the existing API whilemoving the heavy discrete convolution logic into Rust. The PR also adds Rust coverage for the new behavior, including duplicate support aggregation, CDF-to-PDF conversion, and preservation of discrete PDF
metadata.
Testing
Validate the Rust changes:
make cargo-checkmake cargo-testValidate the Python integration:
make checkmake rust-developmake test