feat: add discrete RV subtraction and division operators via FastRV#41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR expands discrete random variable algebra across the Rust core and the Python API.
On the Rust side, it adds
Sub,SubAssign,Div,DivAssign, andMulAssignsupport forRandomVariable, using the discrete transform machinery to implement subtraction by negating the RHSand division by multiplying by the transformed reciprocal. It also adds validation for discrete
transformations, including checks for empty transformation lists, invalid or non-adjacent ranges,
incomplete support coverage, and divide-by-zero support in RV division.
To support those operations, shared sorting and support de-duplication logic was extracted into a new
sharedmodule and reused by convolution, product, mixture, and transform code. The branch also addsdoc tests and unit coverage for the new algebra operations and the shared helpers.
On the Python side,
RVnow routes discrete RV-to-RV+,-,*, and/operations throughFastRV, and the Rust-backed Python API now exposes the corresponding reflected and direct operatormethods. Error handling was updated so divide-by-zero and similar Rust-side failures surface as
ValueError, and the Python lint target was adjusted to runruffwithuv --no-sync.Testing
Run the Rust checks and tests:
make cargo-checkmake cargo-testRun the Python checks and tests:
make checkmake rust-developmake test