Skip to content

[FIX] RNS Resolution#4363

Open
ahsan-javaiid wants to merge 1 commit intoMyCryptoHQ:masterfrom
ahsan-javaiid:fix/rns-resolution
Open

[FIX] RNS Resolution#4363
ahsan-javaiid wants to merge 1 commit intoMyCryptoHQ:masterfrom
ahsan-javaiid:fix/rns-resolution

Conversation

@ahsan-javaiid
Copy link
Copy Markdown

Description

This PR fixes RNS resolution issue on send screen. There are two reasons due to which RNS names are not resolving.

  1. Network is hardcoded in lookup field component here:
    const provider = new ProviderHandler(ethNetwork);
  2. In case of RSK network RPC provider does not know RNS registry address:
    return new StaticJsonRpcProvider(connection, chainId);
    which in case of eth, points to correct address.

Changes

  1. Remove hardcoded network in lookup field component
  2. Set RNS registry address inside provider in case of RSK network

Demo

mycrypto-demo.mp4

Steps to test

  1. Select RSK network
  2. Enter any rns name in the address field
  3. Name should resolve to address

@alepc253
Copy link
Copy Markdown
Contributor

alepc253 commented Mar 8, 2023

@FrederikBolding could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants