Test tutorial#373
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Align Study references with the added sample designs
When a user follows the tutorial with the filled workbooks added here, the Study workbook resolves sample!F through the hidden SBH_sampledesigns_collection, but those entries are Ecosc2_m9, Ecosc2_m9_IPTG, etc. while MD5_SampleDesign_filled.xlsm creates IDs like ecosc2_in_m9 and ecosc2_in_m9_with_iptg. That makes the Study upload link to the hard-coded dryrun_sampledesigns objects instead of the sample designs the user just uploaded, so the tutorial data are not self-consistent.
Align SampleDesign references with the added strain ID
When the tutorial is run with the newly added Strain and SampleDesign workbooks, MD5_Strain_filled.xlsm creates the strain ID ecolisc2, but MD5_SampleDesign_filled.xlsm references Ecolisc2 in SBH_strains_collection and in the sample-design rows. Because those values are used as SBH lookup keys/URI display IDs, the sample-design upload will point at a different hard-coded strain URI rather than the strain produced by the supplied workbook.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
No description provided.