Conversation
Includes ForecastSimulator, ParticleFilterSimulator, and EnsembleKalmanFilterSimulator as top-level interfaces.
…naries of unknown parameters to have consistent usage of keys when iterating over them.
…hood with an `EnsembleKalmanFilterSimulator`.
… likelihood in terms of standard deviation for consistency. Added and updated documentation and annotations.
…naries of unknown parameters to have consistent usage of keys when iterating over them.
…hood with an `EnsembleKalmanFilterSimulator`.
… likelihood in terms of standard deviation for consistency. Added and updated documentation and annotations.
…/Epymorph into Forecasting-Code-Cleanup
JavadocMD
left a comment
There was a problem hiding this comment.
Looking much better, thanks! Just a few minor things, see inline.
…valued hyperparameters.
…e "realizations" as the first dimension.
|
Is it possible to split up some of the code in |
There are a number of tricks to accomplish this. For instance, notice the epymorph.tools.data module defines its own You can also move certain foundational entities to a third module, if they don't require many imports themselves. There are certain guidelines that can help organize imports; I thought about enforcing them with tools at one point. Anyway, I'm happy to chat about specifics if it's helpful. |
|
Thank you! That’s very helpful. |
Miscellaneous cleanup which includes: