Skip to content

Update test_team_sei.py#123

Open
smoore3 wants to merge 1 commit into
mainfrom
smoore3-patch-7
Open

Update test_team_sei.py#123
smoore3 wants to merge 1 commit into
mainfrom
smoore3-patch-7

Conversation

@smoore3

@smoore3 smoore3 commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@claesmk

claesmk commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

You have multiple pull requests open and have created multiple branches in the class repo. Is there a reason you are not using your fork? It does not look like you have synced it. This branch does not have all the code necessary so unit-test is failing.

@smoore3 smoore3 closed this Oct 25, 2022
@smoore3 smoore3 reopened this Oct 25, 2022
@smoore3

smoore3 commented Oct 25, 2022

Copy link
Copy Markdown
Contributor Author

@claesmk > You have multiple pull requests open and have created multiple branches in the class repo. Is there a reason you are not using your fork? It does not look like you have synced it. This branch does not have all the code necessary so unit-test is failing.

The instructions were very vague, so I wasnt exactly sure that thats that I was supposed to be doing

@claesmk

claesmk commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

@smoore3 sorry if the instructions were unclear

You should use the same method to sync your fork and add code you learned in Sprint-1

The main thing as this point is to get all of your code into your smoore3-patch-7 branch. Right now it has the test cases but not the regex changes so that's why your unit test is failing. If you add that and push it should work OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants