Completed AU_TFN test cases#57
Merged
Merged
Conversation
claesmk
requested changes
Oct 17, 2025
claesmk
left a comment
claesmk
left a comment
Contributor
There was a problem hiding this comment.
I don't know why these changes were required. AU_TFN uses a checksum which you can see implemented here that your test numbers do not conform to. It would be better to use valid AU_TFN numbers than to re-write the recognizer.
claesmk
approved these changes
Oct 22, 2025
claesmk
left a comment
claesmk
left a comment
Contributor
There was a problem hiding this comment.
I removed the extra analyzer object and used the default analyze_text instead.
Contributor
|
@KanyliaR you should be all set to update branch, merge, and delete your branch and Codespaces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AU_TFN positive and negative test cases completed