Skip to content

Added IBAN_CODE testcases#73

Merged
franklant merged 2 commits into
mainfrom
3-detect-iban_code
Feb 20, 2026
Merged

Added IBAN_CODE testcases#73
franklant merged 2 commits into
mainfrom
3-detect-iban_code

Conversation

@franklant

Copy link
Copy Markdown
Contributor

No description provided.

@franklant franklant added this to the Sprint-2 milestone Feb 18, 2026
@franklant franklant self-assigned this Feb 18, 2026
@franklant franklant linked an issue Feb 18, 2026 that may be closed by this pull request

@Ziegan-S Ziegan-S left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple issues that could be address, otherwise functionality and readability is really good, changes aren't necessary but could improve what we already have.

Comment thread test_team_praise_him.py Outdated
Comment thread test_team_praise_him.py Outdated

@claesmk claesmk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work validating the check digit.

@franklant franklant merged commit a1bca90 into main Feb 20, 2026
1 check passed
@franklant franklant deleted the 3-detect-iban_code branch February 20, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect IBAN_CODE

3 participants