Add C# port of the MassData Parameter API by Copilot · Pull Request #41 · NEVSTOP-LAB/CSM-MassData-Parameter-Support

Copilot · 2026-04-25T12:13:41Z

Provides a C# implementation of the CSM MassData Parameter Support API, on par with the C port from #40, so .NET callers can exchange MassData reference strings with LabVIEW / C peers.

Library (`csharp/src/CsmMassData/`)

CsmMassData static class with the six methods matching the LabVIEW VIs / C functions (ConfigMassDataParameterCacheSize, ConvertMassDataToArgument[WithDataType], ConvertArgumentToMassData, MassDataDataTypeString, MassDataParameterStatus).
CsmMassDataStatus enum mirrors csm_massdata_status_t numerically; errors surface as CsmMassDataException exposing that status — idiomatic for .NET while keeping cross-language error parity.
Shared ring buffer initialized via static field initializers (CLR once-only guarantee) and serialized by a single lock.
Parser ports the hardening from Add C-language port of the MassData API with a Visual Studio 2026 test project #40: ulong overflow rejection on Start/Size, DataType charset validation (no ; < >), no trailing junk allowed, and pre-add overflow check on start + size in the residency test.
All comments / XML doc are in Chinese, matching the convention established in Add C-language port of the MassData API with a Visual Studio 2026 test project #40.

Tests (`csharp/_test/vs/`)

MSTest project with 11 tests covering config/status, plain & typed round-trips, datatype absence, parse errors (including ulong overflow), overwrite detection, cache-too-small, status reflection, forbidden-character rejection, empty payloads, and an 8-thread stress test.
VS2026 .sln (# Visual Studio Version 18); [assembly: DoNotParallelize] since the API has process-wide shared state.

Repo plumbing

csharp/** added to paths-ignore in Build_VIPM_Library.yml and Check_Broken_VIs.yml.
.gitignore extended with csharp/**/{bin,obj,Debug,Release,x64,x86,.vs}/ and *.user / *.suo.

Usage

using Csm.MassData;

CsmMassData.ConfigMassDataParameterCacheSize(64 * 1024 * 1024);
string arg = CsmMassData.ConvertMassDataToArgumentWithDataType(samples, "1D DBL");
// ... ship `arg` over the CSM bus ...
byte[] restored = CsmMassData.ConvertArgumentToMassData(arg);

Agent-Logs-Url: https://github.com/NEVSTOP-LAB/CSM-MassData-Parameter-Support/sessions/c873d775-c857-4dc9-b4f2-35d49f003ed8 Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com>

Copilot

Pull request overview

Adds a .NET (C#) implementation of the CSM MassData Parameter Support API so .NET callers can exchange MassData reference strings with LabVIEW/C peers, with matching status semantics and a dedicated MSTest suite.

Changes:

Introduces Csm.MassData library (CsmMassData, status enum, exception type, operation struct) implementing the MassData ring-buffer encode/decode + parsing hardening.
Adds MSTest project/solution validating round-trips, error/status behavior, overwrite detection, and multi-thread stress.
Updates repo plumbing: ignore csharp/** in LabVIEW-focused workflows and add C# build artifacts to .gitignore.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
csharp/src/CsmMassData/CsmMassDataStatus.cs	Adds C-aligned status enum for .NET.
csharp/src/CsmMassData/CsmMassDataOperation.cs	Adds operation descriptor struct matching LabVIEW status cluster semantics.
csharp/src/CsmMassData/CsmMassDataException.cs	Adds exception type carrying `CsmMassDataStatus`.
csharp/src/CsmMassData/CsmMassData.csproj	Adds .NET 8 SDK-style library project.
csharp/src/CsmMassData/CsmMassData.cs	Core ring buffer, encoder/decoder, parser, and status APIs.
csharp/_test/vs/CsmMassData.Tests/MSTestSettings.cs	Disables parallel test execution at assembly level.
csharp/_test/vs/CsmMassData.Tests/CsmMassDataTests.cs	End-to-end MSTest coverage for the new API.
csharp/_test/vs/CsmMassData.Tests/CsmMassData.Tests.csproj	Adds MSTest project referencing the library.
csharp/_test/vs/CsmMassData.Tests.sln	Visual Studio solution for running the tests.
csharp/README.md	Documents layout, API mapping, usage, and test instructions.
.gitignore	Ignores C# build artifacts under `csharp/`.
.github/workflows/Check_Broken_VIs.yml	Prevents C#-only changes from triggering LabVIEW workflow.
.github/workflows/Build_VIPM_Library.yml	Prevents C#-only changes from triggering VIPM build workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-25T15:35:22Z

+        if (dataType is not null)
+        {
+            // 数据类型不能包含会破坏引用字符串语法的字符。
+            if (dataType.IndexOfAny(new[] { ';', '<', '>' }) >= 0)
+            {
+                throw new CsmMassDataException(
+                    CsmMassDataStatus.InvalidArgument,
+                    "dataType 中不允许出现 ';'、'<' 或 '>' 字符。");
+            }


dataType.IndexOfAny 这里每次都会 new 一个 char[]，在高频编码场景会产生不必要的分配。建议改为复用静态 readonly char[]（或改为分别 Contains(';') / Contains('<') / Contains('>')）以避免每次调用分配。

Copilot · 2026-04-25T15:35:22Z

+    /// </remarks>
+    /// <param name="data">待保存的原始字节，<c>null</c> 视为空数据。</param>
+    /// <returns>MassData 参数字符串。</returns>
+    /// <exception cref="CsmMassDataException">编码过程中检测到错误时抛出。</exception>
+    public static string ConvertMassDataToArgument(ReadOnlySpan<byte> data)
+        => Encode(data, dataType: null);


该重载的参数类型是 ReadOnlySpan，在 C# 里不可能为 null，但 XML 注释仍写了“null 视为空数据”。建议把这条说明移到 byte[]? 重载，或改为说明空 Span 等价于空数据，以免误导调用方。

Copilot · 2026-04-25T15:35:22Z

+    /// 非空的数据类型字符串（例如 <c>"1D I32"</c>）；不允许包含
+    /// <c>';'</c>、<c>'&lt;'</c> 或 <c>'&gt;'</c>。


这里的注释写“非空的数据类型字符串”，但实现仅拒绝 null/非法字符/过长，并未拒绝空字符串；C 端实现同样允许空字符串。建议要么在实现中显式拒绝空字符串，要么把注释改为“可为空字符串但不能为 null”，保证文档与行为一致。

Suggested change

/// 非空的数据类型字符串（例如 <c>"1D I32"</c>）；不允许包含

/// <c>';'</c>、<c>'<'</c> 或 <c>'>'</c>。

/// 可为空字符串但不能为 <c>null</c> 的数据类型字符串（例如 <c>"1D I32"</c>）；

/// 不允许包含 <c>';'</c>、<c>'<'</c> 或 <c>'>'</c>。

nevstop · 2026-04-25T15:42:48Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/NEVSTOP-LAB/CSM-MassData-Parameter-Support/sessions/6d5c31c7-6690-46c5-8d1e-ba2a6dae5ac7 Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com>

Copilot · 2026-04-25T15:44:24Z

@copilot apply changes based on the comments in this thread

已在 88d816d 中处理三处反馈：1) 将 IndexOfAny 使用的 char[] 提取为 static readonly ForbiddenDataTypeChars，避免每次编码时分配；2) ReadOnlySpan<byte> 重载的 <param> 改为“空 Span 等价于不写入任何数据”，不再误导性地提“null”；3) dataType 注释从“非空”改为“可为空字符串但不能为 null”，与实现及 C 端行为一致。

nevstop · 2026-04-26T02:53:54Z

@copilot 解决冲突的问题

…pport-to-massdata # Conflicts: # .gitignore Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com>

Copilot · 2026-04-26T02:55:30Z

@copilot 解决冲突的问题

已在 b61a14d 中合并 origin/main 并解决 .gitignore 冲突（保留 csharp/ 与 python/ 两段忽略规则）。合并后 dotnet test 11/11 通过。

Initial plan

407eab5

Copilot AI assigned Copilot and nevstop Apr 25, 2026

github-project-automation Bot added this to Communicable State Machine(CSM) Apr 25, 2026

Copilot started work on behalf of nevstop April 25, 2026 12:13 View session

Copilot AI linked an issue Apr 25, 2026 that may be closed by this pull request

massdata 的第三方语言支持: C# #37

Closed

Add C# port of CSM MassData API with VS2026 test solution

cb33417

Agent-Logs-Url: https://github.com/NEVSTOP-LAB/CSM-MassData-Parameter-Support/sessions/c873d775-c857-4dc9-b4f2-35d49f003ed8 Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add third-party language support for C# in massdata~~ Add C# port of the MassData Parameter API Apr 25, 2026

Copilot AI requested a review from nevstop April 25, 2026 12:25

Copilot finished work on behalf of nevstop April 25, 2026 12:25

nevstop requested a review from Copilot April 25, 2026 15:32

Copilot started reviewing on behalf of nevstop April 25, 2026 15:32 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Copilot started work on behalf of nevstop April 25, 2026 15:42 View session

Address PR review: avoid char[] allocation, fix XML doc on Span/dataType

88d816d

Agent-Logs-Url: https://github.com/NEVSTOP-LAB/CSM-MassData-Parameter-Support/sessions/6d5c31c7-6690-46c5-8d1e-ba2a6dae5ac7 Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com>

Copilot finished work on behalf of nevstop April 25, 2026 15:44

nevstop approved these changes Apr 25, 2026

View reviewed changes

nevstop marked this pull request as ready for review April 25, 2026 16:07

Copilot started work on behalf of nevstop April 26, 2026 02:54 View session

Merge remote-tracking branch 'origin/main' into copilot/add-csharp-su…

b61a14d

…pport-to-massdata # Conflicts: # .gitignore Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com>

Copilot AI requested a review from nevstop April 26, 2026 02:55

Copilot finished work on behalf of nevstop April 26, 2026 02:55

nevstop merged commit 6d754bc into main Apr 26, 2026

nevstop deleted the copilot/add-csharp-support-to-massdata branch April 26, 2026 03:29

github-project-automation Bot moved this to Done in Communicable State Machine(CSM) Apr 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add C# port of the MassData Parameter API#41

Add C# port of the MassData Parameter API#41
nevstop merged 4 commits into
mainfrom
copilot/add-csharp-support-to-massdata

Copilot AI commented Apr 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

nevstop commented Apr 25, 2026

Uh oh!

Copilot AI commented Apr 25, 2026

Uh oh!

nevstop commented Apr 26, 2026

Uh oh!

Copilot AI commented Apr 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		/// 非空的数据类型字符串（例如 <c>"1D I32"</c>）；不允许包含
		/// <c>';'</c>、<c>'<'</c> 或 <c>'>'</c>。

Conversation

Copilot AI commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Library (csharp/src/CsmMassData/)

Tests (csharp/_test/vs/)

Repo plumbing

Usage

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

nevstop commented Apr 25, 2026

Uh oh!

Copilot AI commented Apr 25, 2026

Uh oh!

nevstop commented Apr 26, 2026

Uh oh!

Copilot AI commented Apr 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 25, 2026 •

edited

Loading

Library (`csharp/src/CsmMassData/`)

Tests (`csharp/_test/vs/`)