Skip to content

Update: [AEA-6075] - Includes mock logger in packaged code #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JackSpagnoliNHS wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update: [AEA-6075] - Includes mock logger in packaged code #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87264fd
adds toml extension
JackSpagnoliNHS Jan 22, 2026
3f19d1f
moves mock logger into exported package
JackSpagnoliNHS Jan 22, 2026
841e185
removes eslint
JackSpagnoliNHS Jan 22, 2026
fe17dfa
uses wrapped logger
JackSpagnoliNHS Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
"ms-python.flake8",
"eamodio.gitlens",
"github.vscode-pull-request-github",
"dbaeumer.vscode-eslint",
"lfm.vscode-makefile-term",
"streetsidesoftware.code-spell-checker",
"timonwong.shellcheck",
"github.vscode-github-actions"
"github.vscode-github-actions",
"tamasfe.even-better-toml"
],
"settings": {
"python.defaultInterpreterPath": "/home/vscode/.asdf/shims/python",
Expand Down
6 changes: 3 additions & 3 deletions src/eps_spine_shared/common/dynamodb_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ def __init__(

resource_args = {"service_name": SERVICE_NAME, "region_name": REGION_NAME}
if aws_endpoint_url:
log_object.write_log("DDB0003", None, {"awsEndpointUrl": aws_endpoint_url})
self.log_object.write_log("DDB0003", None, {"awsEndpointUrl": aws_endpoint_url})
resource_args["endpoint_url"] = aws_endpoint_url
else:
log_object.write_log("DDB0004", None)
self.log_object.write_log("DDB0004", None)

self.resource = session.resource(**resource_args)
self.table = self.resource.Table(table_name)
Expand All @@ -82,7 +82,7 @@ def __init__(
self.deserialiser = TypeDeserializer()
self.serialiser = TypeSerializer()
except Exception as ex:
log_object.write_log("DDB0000", sys.exc_info(), {"error": str(ex)})
self.log_object.write_log("DDB0000", sys.exc_info(), {"error": str(ex)})
raise ex

self.log_object.write_log("DDB0001", None, {"tableName": table_name})
Expand Down
0 tests/mock_logger.py → src/eps_spine_shared/testing/mock_logger.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion tests/common/dynamodb_datastore_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
from eps_spine_shared.common.dynamodb_datastore import EpsDynamoDbDataStore
from eps_spine_shared.common.prescription.record import PrescriptionStatus
from eps_spine_shared.nhsfundamentals.timeutilities import TimeFormats
from eps_spine_shared.testing.mock_logger import MockLogObject
from tests.dynamodb_test import DynamoDbTest
from tests.mock_logger import MockLogObject


class EpsDynamoDbDataStoreTest(DynamoDbTest):
Expand Down
2 changes: 1 addition & 1 deletion tests/common/indexes_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from eps_spine_shared.common.prescription.repeat_prescribe import RepeatPrescribeRecord
from eps_spine_shared.common.prescription.single_prescribe import SinglePrescribeRecord
from eps_spine_shared.common.prescription.types import PrescriptionTreatmentType
from tests.mock_logger import MockLogObject
from eps_spine_shared.testing.mock_logger import MockLogObject


def get_nad_references():
Expand Down
2 changes: 1 addition & 1 deletion tests/common/prescription/record_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from eps_spine_shared.common.prescription.types import PrescriptionTreatmentType
from eps_spine_shared.errors import EpsSystemError
from eps_spine_shared.nhsfundamentals.timeutilities import TimeFormats
from tests.mock_logger import MockLogObject
from eps_spine_shared.testing.mock_logger import MockLogObject


def load_test_example_json(mock_log_object, filename):
Expand Down
2 changes: 1 addition & 1 deletion tests/dynamodb_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from eps_spine_shared.common.dynamodb_common import SortKey
from eps_spine_shared.common.dynamodb_datastore import EpsDynamoDbDataStore
from eps_spine_shared.common.prescription.record import PrescriptionStatus
from tests.mock_logger import MockLogObject
from eps_spine_shared.testing.mock_logger import MockLogObject

PRESC_ORG = "X26"
DISP_ORG = "X27"
Expand Down