Skip to content

NPA-6165: Superseed performer for grantee in consent #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellie-bound1-NHSD merged 11 commits into from
Jan 29, 2026
Merged

NPA-6165: Superseed performer for grantee in consent #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
418d8fe
NPA-6165: Update OAS to deprecate the performer property and instead …
ellie-bound1-NHSD Jan 21, 2026
9f1fd4a
NPA-6165: Update POST Consent request examples and GET Consent respon…
ellie-bound1-NHSD Jan 21, 2026
1a10a96
NPA-6165: Postman Collection Updates
ellie-bound1-NHSD Jan 22, 2026
a8540f6
NPA-6165: UPdate spec
ellie-bound1-NHSD Jan 23, 2026
02eaffc
NPA-6165: Update error respones for post consent
ellie-bound1-NHSD Jan 26, 2026
f60ac75
NPA-6165: Restore postman
ellie-bound1-NHSD Jan 26, 2026
ebb6a46
NPA-6165: Update postman collections
ellie-bound1-NHSD Jan 27, 2026
ad1b9fe
NPA-6165: Update URL for grantee extension
ellie-bound1-NHSD Jan 27, 2026
7de193a
NPA-6165: Fix spec
ellie-bound1-NHSD Jan 27, 2026
899b525
Merge branch 'master' into story/NPA-6165/superseed-performer-for-gra…
ellie-bound1-NHSD Jan 27, 2026
6169833
NPA-6165: Review Comments
ellie-bound1-NHSD Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18,478 changes: 9,238 additions & 9,240 deletions postman/validated_relationship_service.integration.postman_collection.json
View file
Open in desktop

Large diffs are not rendered by default.

22,080 changes: 10,917 additions & 11,163 deletions postman/validated_relationship_service.sandbox.postman_collection.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion sandbox/api/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
POST_CONSENT__DIRECTORY = "./api/examples/POST_Consent/"
POST_CONSENT__SUCCESS = f"{POST_CONSENT__DIRECTORY}success.yaml"
POST_CONSENT__DUPLICATE_RELATIONSHIP_ERROR = f"{POST_CONSENT__DIRECTORY}errors/duplicate_relationship_error.yaml"
POST_CONSENT__PERFORMER_IDENTIFIER_ERROR = f"{POST_CONSENT__DIRECTORY}errors/invalid_performer_identifier_error.yaml"
POST_CONSENT__MISSING_FREE_TEXT_FOR_OTHER = f"{POST_CONSENT__DIRECTORY}errors/missing_free_text_for_other.yaml"

# PATCH Consent
Expand Down
5 changes: 0 additions & 5 deletions sandbox/api/post_consent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from .constants import (
INTERNAL_SERVER_ERROR_EXAMPLE,
POST_CONSENT__DUPLICATE_RELATIONSHIP_ERROR,
POST_CONSENT__PERFORMER_IDENTIFIER_ERROR,
POST_CONSENT__SUCCESS,
POST_CONSENT__MISSING_FREE_TEXT_FOR_OTHER,
)
Expand Down Expand Up @@ -40,10 +39,6 @@ def post_consent_response() -> Union[dict, tuple]:
elif patient_identifier == "9000000049":
response = generate_response_from_example(POST_CONSENT__DUPLICATE_RELATIONSHIP_ERROR, 409)

# Invalid performer NHS number
elif patient_identifier == "9000000000":
response = generate_response_from_example(POST_CONSENT__PERFORMER_IDENTIFIER_ERROR, 422)

elif patient_identifier == "9000000050":
# Missing free text for OTHER reason code (should fail)
response = generate_response_from_example(POST_CONSENT__MISSING_FREE_TEXT_FOR_OTHER, 400)
Expand Down
2 changes: 0 additions & 2 deletions sandbox/api/tests/test_post_consent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

from sandbox.api.constants import (
POST_CONSENT__DUPLICATE_RELATIONSHIP_ERROR,
POST_CONSENT__PERFORMER_IDENTIFIER_ERROR,
POST_CONSENT__SUCCESS,
POST_CONSENT__MISSING_FREE_TEXT_FOR_OTHER,
)
Expand All @@ -29,7 +28,6 @@
201,
"90b9863e-e33c-4895-a333-fd0ea0e23205",
),
("9000000000", POST_CONSENT__PERFORMER_IDENTIFIER_ERROR, 422, None),
("9000000049", POST_CONSENT__DUPLICATE_RELATIONSHIP_ERROR, 409, None),
(
"9000000050",
Expand Down
10 changes: 5 additions & 5 deletions specification/examples/requests/POST_Consent/adult_to_adult_proxy_creation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ ConsentAdultToAdultGuardianRequest:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000012"
dateTime: "2025-02-11T14:30:00Z"
performer:
- type: RelatedPerson
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000017"
provision:
type: permit
period:
Expand All @@ -46,3 +41,8 @@ ConsentAdultToAdultGuardianRequest:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
10 changes: 5 additions & 5 deletions specification/examples/requests/POST_Consent/parent_child_proxy_creation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ ConsentParentChildProxyCreationRequest:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000012"
dateTime: "2025-02-11T14:30:00Z"
performer:
- type: RelatedPerson
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: "9000000009"
provision:
type: permit
period:
Expand All @@ -47,3 +42,8 @@ ConsentParentChildProxyCreationRequest:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000009'
18 changes: 10 additions & 8 deletions .../examples/responses/GET_Consent/filtered-relationships-status-active-include-details.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,6 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
system: "https://fhir.nhs.uk/Id/nhs-number"
value: "9000000009"
dateTime: "2024-07-21T17:32:28Z"
performer:
- identifier:
system: "https://fhir.nhs.uk/Id/nhs-number"
value: "9000000017"
policy:
- authority: "https://www.england.nhs.uk"
uri: "REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD"
Expand All @@ -115,6 +111,11 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
search:
mode: match
- fullUrl: "https://api.service.nhs.uk/validated-relationships/FHIR/R4/RelatedPerson/RP974720"
Expand Down Expand Up @@ -184,10 +185,6 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
system: "https://fhir.nhs.uk/Id/nhs-number"
value: "9000000005"
dateTime: "2024-07-21T17:32:28Z"
performer:
- identifier:
system: "https://fhir.nhs.uk/Id/nhs-number"
value: "9000000017"
policy:
- authority: "https://www.england.nhs.uk"
uri: "REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD"
Expand All @@ -213,5 +210,10 @@ ConsentMultipleRelationshipsStatusActiveIncludeDetailsBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
search:
mode: match
18 changes: 10 additions & 8 deletions specification/examples/responses/GET_Consent/filtered-relationships-status-inactive.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ ConsentMultipleRelationshipsStatusInactiveBundle:
system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9000000006'
dateTime: '2024-07-21T17:32:28Z'
performer:
- identifier:
system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9000000017'
policy:
- authority: https://www.england.nhs.uk
uri: REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD
Expand All @@ -59,6 +55,11 @@ ConsentMultipleRelationshipsStatusInactiveBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_DEACTIVATED_END_DATE_REACHED
display: End date reached
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
search:
mode: match
- fullUrl: https://api.service.nhs.uk/validated-relationships/FHIR/R4/Consent/ABCD12B3
Expand All @@ -81,10 +82,6 @@ ConsentMultipleRelationshipsStatusInactiveBundle:
system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9000000007'
dateTime: '2024-07-21T17:32:28Z'
performer:
- identifier:
system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9000000017'
policy:
- authority: https://www.england.nhs.uk
uri: REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD
Expand All @@ -111,5 +108,10 @@ ConsentMultipleRelationshipsStatusInactiveBundle:
code: OTHER
display: Other reason
text: Patient would not respond to phone calls
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
search:
mode: match
36 changes: 20 additions & 16 deletions ...ication/examples/responses/GET_Consent/filtered-relationships-status-proposed-active.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9000000009'
dateTime: '2024-07-21T17:32:28Z'
performer:
- identifier:
system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9000000017'
policy:
- authority: https://www.england.nhs.uk
uri: REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD
Expand All @@ -59,6 +55,11 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
search:
mode: match

Expand All @@ -82,10 +83,6 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9000000005'
dateTime: '2024-07-21T17:32:28Z'
performer:
- identifier:
system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9000000017'
policy:
- authority: https://www.england.nhs.uk
uri: REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD
Expand All @@ -111,6 +108,11 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
search:
mode: match

Expand All @@ -134,10 +136,6 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9000000020'
dateTime: '2024-07-21T17:32:28Z'
performer:
- identifier:
system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9000000017'
policy:
- authority: https://www.england.nhs.uk
uri: REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD
Expand All @@ -163,6 +161,11 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: APPLICATION_SUBMITTED
display: Application submitted online
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
search:
mode: match

Expand All @@ -186,10 +189,6 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9000000021'
dateTime: '2024-07-21T17:32:28Z'
performer:
- identifier:
system: 'https://fhir.nhs.uk/Id/nhs-number'
value: '9000000017'
policy:
- authority: https://www.england.nhs.uk
uri: REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD
Expand All @@ -215,5 +214,10 @@ ConsentMultipleRelationshipsStatusProposedActiveBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: APPLICATION_SUBMITTED
display: Application submitted online
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000017'
search:
mode: match
27 changes: 15 additions & 12 deletions specification/examples/responses/GET_Consent/multiple-relationships-include-patient.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ ConsentMultipleRelationshipsIncludePatientBundle:
system: "https://fhir.nhs.uk/Id/nhs-number"
value: "9000000009"
dateTime: "2024-07-21T17:32:28Z"
performer:
- identifier:
system: "https://fhir.nhs.uk/Id/nhs-number"
value: "9000000022"
policy:
- authority: https://www.england.nhs.uk
uri: REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD
Expand All @@ -91,6 +87,11 @@ ConsentMultipleRelationshipsIncludePatientBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000022'
search:
mode: match
- fullUrl: https://api.service.nhs.uk/validated-relationships/FHIR/R4/Patient/DFCC67F5
Expand Down Expand Up @@ -142,10 +143,6 @@ ConsentMultipleRelationshipsIncludePatientBundle:
system: "https://fhir.nhs.uk/Id/nhs-number"
value: "9000000005"
dateTime: "2024-07-21T17:32:28Z"
performer:
- identifier:
system: "https://fhir.nhs.uk/Id/nhs-number"
value: "9000000022"
policy:
- authority: https://www.england.nhs.uk
uri: REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD
Expand All @@ -171,6 +168,11 @@ ConsentMultipleRelationshipsIncludePatientBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_CREATED
display: Role created
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000022'
search:
mode: match
- fullUrl: https://api.service.nhs.uk/validated-relationships/FHIR/R4/Patient/ZPTT32T3
Expand Down Expand Up @@ -222,10 +224,6 @@ ConsentMultipleRelationshipsIncludePatientBundle:
system: "https://fhir.nhs.uk/Id/nhs-number"
value: "9000000006"
dateTime: "2024-07-21T17:32:28Z"
performer:
- identifier:
system: "https://fhir.nhs.uk/Id/nhs-number"
value: "9000000022"
policy:
- authority: https://www.england.nhs.uk
uri: REPLACE_WITH_LINK_TO_PUBLISHED_NATIONAL_PROXY_STANDARD
Expand All @@ -251,5 +249,10 @@ ConsentMultipleRelationshipsIncludePatientBundle:
- system: https://fhir.nhs.uk/England/CodeSystem/England-ConsentStatusReason
code: ROLE_DEACTIVATED_END_DATE_REACHED
display: End date reached
- url: https://hl7.org/fhir/5.0/StructureDefinition/extension-Consent.grantee
valueReference:
identifier:
system: https://fhir.nhs.uk/Id/nhs-number
value: '9000000022'
search:
mode: match
Loading