111 batch running features gpu runner#142
Merged
Merged
Conversation
…NativeRunner::report_simulation
…-running-features---gpu-runner
…o single structure
…op to leverage the structure better
…e SolTraceSystem::run
…ax with max rays; add/remove tests
…ray count through optix runner
…max trace depth count test
Collaborator
Author
Collaborator
taylorbrown75
left a comment
There was a problem hiding this comment.
Tests pass on my windows machine. Only concern is whether we mark rays as EXIT on the gpu runner.
| if (ht < HIT_CREATE || ht > HIT_EXIT) | ||
| break; | ||
| ++raw_count; | ||
| if (ht == HIT_ABSORB || ht == HIT_EXIT) |
Collaborator
There was a problem hiding this comment.
Is HIT_EXIT ever assigned in the GPU runner? The miss function in materials.cu does not set that value currently. There could be cases where rays exit the scene on the last available depth slot, but because it is not absorbed or marked as exit, it will be added to passed max depth counter.
Collaborator
Author
There was a problem hiding this comment.
The atomic counter for the max depth exceeded is incremented in the materials.cu (above). If I understand the flow correctly, it should only get there if there is an intersection with an element. In which case that is not registered because it exceeds max depth. So only non HIT_EXIT rays should get counted.
Currently, we do not assign HIT_EXIT in the optix runner.
Collaborator
There was a problem hiding this comment.
This makes sense to me, thank you for the clarification!
taylorbrown75
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement/do the following for the OptixRunner: