Skip to content

Patch: Enable custom array design layout generation for WOMBAT compatibility#707

Merged
gbarter merged 4 commits intoNLRWindSystems:developfrom
RHammond2:patch/orbit-layout-generation
Apr 10, 2026
Merged

Patch: Enable custom array design layout generation for WOMBAT compatibility#707
gbarter merged 4 commits intoNLRWindSystems:developfrom
RHammond2:patch/orbit-layout-generation

Conversation

@RHammond2
Copy link
Copy Markdown
Contributor

@RHammond2 RHammond2 commented Apr 2, 2026

Purpose

This PR allows for the use of ORBIT's CustomArraySystemDesign tooling when capturing the WOMBAT-compatible layout data by using the latest ORBIT patch and adding better control flow to the ORBIT compute() method. I have also added a missing __version__ attribute that should be made available for Python libraries.

Closes #703

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

N/A

Checklist

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@cfrontin
Copy link
Copy Markdown
Contributor

cfrontin commented Apr 2, 2026

I just built this out and ran the unit tests in Ard; the custom array layout issues described in #703 are resolved!

@gbarter gbarter changed the base branch from master to develop April 8, 2026 13:02
@gbarter gbarter merged commit e0de90e into NLRWindSystems:develop Apr 10, 2026
12 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ORBIT API fails for CustomArraySystemDesign

3 participants