[production/GFS.v17] Remove ufs_logfhour call and add log_restart_fh#112
Merged
dpsarmie merged 1 commit intoMay 27, 2026
Merged
Conversation
Collaborator
Author
|
Ran tests on this and everything looked fine. Should be ready to merge into the production branch. |
19 tasks
NickSzapiro-NOAA
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Remove ufs_logfhour call and add log_restart_fh as the main CICE logging function
Daniel Sarmiento -- NOAA EMC
This was tested using the UFSWM production/GFSv17 suite of regression tests.
There's an NCO requirement for GFSv17 that the logs for each submodule be written into the output directory of that submodule. This PR replaces ufs_logfhour with log_restart_fh and sets the log output directory to be
./CICE_OUTPUT.There will be a develop version of this code that will allow the user to control this feature via the configuration files. For production, this will just be the default behavior.