Skip to content

[production/GFS.v17] Remove ufs_logfhour call and add log_restart_fh#112

Merged
dpsarmie merged 1 commit into
NOAA-EMC:production/GFS.v17from
dpsarmie:v17/logs_to_output_dir
May 27, 2026
Merged

[production/GFS.v17] Remove ufs_logfhour call and add log_restart_fh#112
dpsarmie merged 1 commit into
NOAA-EMC:production/GFS.v17from
dpsarmie:v17/logs_to_output_dir

Conversation

@dpsarmie
Copy link
Copy Markdown
Collaborator

@dpsarmie dpsarmie commented May 26, 2026

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Remove ufs_logfhour call and add log_restart_fh as the main CICE logging function
  • Developer(s):
    Daniel Sarmiento -- NOAA EMC
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    This was tested using the UFSWM production/GFSv17 suite of regression tests.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

There's an NCO requirement for GFSv17 that the logs for each submodule be written into the output directory of that submodule. This PR replaces ufs_logfhour with log_restart_fh and sets the log output directory to be ./CICE_OUTPUT.

There will be a develop version of this code that will allow the user to control this feature via the configuration files. For production, this will just be the default behavior.

@dpsarmie dpsarmie marked this pull request as ready for review May 26, 2026 20:04
@dpsarmie
Copy link
Copy Markdown
Collaborator Author

Ran tests on this and everything looked fine. Should be ready to merge into the production branch.

@dpsarmie dpsarmie changed the title Remove ufs_logfhour call and add log_restart_fh [production/GFS.v17] Remove ufs_logfhour call and add log_restart_fh May 26, 2026
@dpsarmie dpsarmie merged commit 77542dc into NOAA-EMC:production/GFS.v17 May 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants