Updating name of smoke tracer for MPAS#1520
Conversation
|
@EricJames-NOAA Could you open a UPP issue to link this PR? Thanks! |
|
@WenMeng-NOAA I have a couple more variables to add to this PR, if that's OK. I will aim to get the code finalized by the end of the day tomorrow. Thanks. |
@EricJames-NOAA Take your time to incorporate additional changes in this PR. |
|
@EricJames-NOAA Do you have a sample MPAS model output that includes new variables you are proposing for our testing? |
@WenMeng-NOAA yes, sorry. I will point you to a file once Ursa comes back from maintenance today. |
@WenMeng-NOAA I have a sample mpassit output file here on Hera/Ursa: /scratch4/BMC/wrfruc/ejames/upp_firewx/mpassit.2026-04-27_01.00.00.nc I think the code is ready to go from my perspective. |
|
@EricJames-NOAA Thanks for sharing your output - I see the new variables in your file. @clyden-noaa This PR is ready for testing on the RDHPCs. There are baseline changes expected for 3DRTMA, RAP, and HRRR related to changes in the metadata. |
| ELSE | ||
| DO J=JSTA,JEND | ||
| DO I=ISTA,IEND | ||
| GRID1(I,J) = MEAN_FRP(I,J) |
There was a problem hiding this comment.
@EricJames-NOAA The UPP RTs indicate this change has impact on the rap, hrrr results. If new unit conversion is intended for MPAS only, would you consider moving the update in the MPAS read interface INITPOST_MPAS.F?
|
@clyden-noaa Sorry, I was a little too quick! Wen and I want to do some more testing related to the baseline changes. Please hold off on running the RTs for now. |
|
@EricJames-NOAA I ran a test with your mpassit output file and postxconfig-NT.txt file on Ursa, and it looks like the new fields are in the GRIB2 files. Could you confirm the results look good? Here is my run directory: Also, @WenMeng-NOAA noticed that AEMFLX (UPP ID 745) and WFIREPOT (UPP ID 755) are not included in the UPP control files for MPAS. Do you suggest adding these two fields to the MPAS control files with your PR, or are they only needed for high-resolution fire weather runs? Thanks! |
@WenMeng-NOAA @BenjaminBlake-NOAA thanks for the comments. I moved the FRP conversion into INITPOST_MPAS.F, and added AEMFLX and WFIREPOT into the rrfs_mpas control files. I tested again, and everything looks good. |
|
@EricJames-NOAA Thanks for addressing our comments. Your changes look good to us! @clyden-noaa This PR is now ready for testing on the RDHPCs. There are baseline changes expected for the MPAS test. I generated new baseline data for you here on Ursa: |
clyden-noaa
left a comment
There was a problem hiding this comment.
@WenMeng-NOAA @BenjaminBlake-NOAA @EricJames-NOAA
All RT testing has been completed
All RTs ran successfully on all RDHPC systems
All RTs ran within established timing thresholds on all RDHPC systems
There were baseline changes for mpas:
- POSTTWO12.tm00
Ursa-Intel
Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'gfs']
No changes in test results detected.
Ursa-Intelllvm
Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'gfs']
No changes in test results detected.
Orion-Intel
Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'gfs']
No changes in test results detected.
Hercules-Intel
Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'gfs']
No changes in test results detected.
|
@WenMeng-NOAA @BenjaminBlake-NOAA |
BenjaminBlake-NOAA
left a comment
There was a problem hiding this comment.
@clyden-noaa Thanks for testing! No need to re-run the RTs - the most recent commits from Eric added UPP control files for a high resolution fire weather run, which is not currently part of the RTs.
This PR is ready for merging.
MPAS uses a different name for the smoke tracer, so we need to update INITPOST_MPAS.F.
The code was tested for a high-resolution fire weather MPAS run on Ursa.