Skip to content

Updating name of smoke tracer for MPAS#1520

Merged
BenjaminBlake-NOAA merged 28 commits into
NOAA-EMC:developfrom
EricJames-NOAA:mpas_smoke_vars
May 11, 2026
Merged

Updating name of smoke tracer for MPAS#1520
BenjaminBlake-NOAA merged 28 commits into
NOAA-EMC:developfrom
EricJames-NOAA:mpas_smoke_vars

Conversation

@EricJames-NOAA
Copy link
Copy Markdown
Contributor

MPAS uses a different name for the smoke tracer, so we need to update INITPOST_MPAS.F.

The code was tested for a high-resolution fire weather MPAS run on Ursa.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@EricJames-NOAA Could you open a UPP issue to link this PR? Thanks!

@WenMeng-NOAA WenMeng-NOAA linked an issue Apr 29, 2026 that may be closed by this pull request
@BenjaminBlake-NOAA BenjaminBlake-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Apr 29, 2026
@EricJames-NOAA
Copy link
Copy Markdown
Contributor Author

@WenMeng-NOAA I have a couple more variables to add to this PR, if that's OK. I will aim to get the code finalized by the end of the day tomorrow. Thanks.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@WenMeng-NOAA I have a couple more variables to add to this PR, if that's OK. I will aim to get the code finalized by the end of the day tomorrow. Thanks.

@EricJames-NOAA Take your time to incorporate additional changes in this PR.

Comment thread sorc/ncep_post.fd/CLDRAD.f Outdated
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@EricJames-NOAA Do you have a sample MPAS model output that includes new variables you are proposing for our testing?

@EricJames-NOAA
Copy link
Copy Markdown
Contributor Author

@EricJames-NOAA Do you have a sample MPAS model output that includes new variables you are proposing for our testing?

@WenMeng-NOAA yes, sorry. I will point you to a file once Ursa comes back from maintenance today.

@EricJames-NOAA
Copy link
Copy Markdown
Contributor Author

@EricJames-NOAA Do you have a sample MPAS model output that includes new variables you are proposing for our testing?

@WenMeng-NOAA yes, sorry. I will point you to a file once Ursa comes back from maintenance today.

@WenMeng-NOAA I have a sample mpassit output file here on Hera/Ursa:

/scratch4/BMC/wrfruc/ejames/upp_firewx/mpassit.2026-04-27_01.00.00.nc

I think the code is ready to go from my perspective.

@BenjaminBlake-NOAA BenjaminBlake-NOAA added Baseline Change The baselines of the UPP regression tests are changed. and removed No Baseline Change No baseline of the UPP regression tests are made. labels May 7, 2026
@BenjaminBlake-NOAA
Copy link
Copy Markdown
Collaborator

@EricJames-NOAA Thanks for sharing your output - I see the new variables in your file.

@clyden-noaa This PR is ready for testing on the RDHPCs. There are baseline changes expected for 3DRTMA, RAP, and HRRR related to changes in the metadata.

Comment thread sorc/ncep_post.fd/CLDRAD.f Outdated
ELSE
DO J=JSTA,JEND
DO I=ISTA,IEND
GRID1(I,J) = MEAN_FRP(I,J)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricJames-NOAA The UPP RTs indicate this change has impact on the rap, hrrr results. If new unit conversion is intended for MPAS only, would you consider moving the update in the MPAS read interface INITPOST_MPAS.F?

@BenjaminBlake-NOAA
Copy link
Copy Markdown
Collaborator

@clyden-noaa Sorry, I was a little too quick! Wen and I want to do some more testing related to the baseline changes. Please hold off on running the RTs for now.

@BenjaminBlake-NOAA
Copy link
Copy Markdown
Collaborator

@EricJames-NOAA I ran a test with your mpassit output file and postxconfig-NT.txt file on Ursa, and it looks like the new fields are in the GRIB2 files. Could you confirm the results look good? Here is my run directory:
/scratch4/NCEPDEV/stmp/Benjamin.Blake/upp-URSA/mpas_2026042700

Also, @WenMeng-NOAA noticed that AEMFLX (UPP ID 745) and WFIREPOT (UPP ID 755) are not included in the UPP control files for MPAS. Do you suggest adding these two fields to the MPAS control files with your PR, or are they only needed for high-resolution fire weather runs?

Thanks!

@EricJames-NOAA
Copy link
Copy Markdown
Contributor Author

@EricJames-NOAA I ran a test with your mpassit output file and postxconfig-NT.txt file on Ursa, and it looks like the new fields are in the GRIB2 files. Could you confirm the results look good? Here is my run directory: /scratch4/NCEPDEV/stmp/Benjamin.Blake/upp-URSA/mpas_2026042700

Also, @WenMeng-NOAA noticed that AEMFLX (UPP ID 745) and WFIREPOT (UPP ID 755) are not included in the UPP control files for MPAS. Do you suggest adding these two fields to the MPAS control files with your PR, or are they only needed for high-resolution fire weather runs?

Thanks!

@WenMeng-NOAA @BenjaminBlake-NOAA thanks for the comments. I moved the FRP conversion into INITPOST_MPAS.F, and added AEMFLX and WFIREPOT into the rrfs_mpas control files. I tested again, and everything looks good.

@BenjaminBlake-NOAA
Copy link
Copy Markdown
Collaborator

@EricJames-NOAA Thanks for addressing our comments. Your changes look good to us!

@clyden-noaa This PR is now ready for testing on the RDHPCs. There are baseline changes expected for the MPAS test. I generated new baseline data for you here on Ursa:

/scratch4/NCEPDEV/stmp/Benjamin.Blake/upp-URSA-intel-1520/mpas_2026032009/POSTTWO12.tm00
/scratch4/NCEPDEV/stmp/Benjamin.Blake/upp-URSA-intelllvm-1520/mpas_2026032009/POSTTWO12.tm00

Copy link
Copy Markdown
Collaborator

@clyden-noaa clyden-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WenMeng-NOAA @BenjaminBlake-NOAA @EricJames-NOAA
All RT testing has been completed
All RTs ran successfully on all RDHPC systems
All RTs ran within established timing thresholds on all RDHPC systems

There were baseline changes for mpas:

  • POSTTWO12.tm00

Ursa-Intel

Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'gfs']
No changes in test results detected.

Ursa-Intelllvm

Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'gfs']
No changes in test results detected.

Orion-Intel

Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'gfs']
No changes in test results detected.

Hercules-Intel

Check tests:
['sfs', 'aqm', 'gefsv12', 'gefsv13', 'nmmb', 'rap', 'hrrr', 'hafs', '3drtma', 'mpas', 'mpas_hfip', 'gcafs', 'rrfs', 'gfs']
No changes in test results detected.

@clyden-noaa
Copy link
Copy Markdown
Collaborator

@WenMeng-NOAA @BenjaminBlake-NOAA
It looks like some changes were committed after I ran the RTs. Should I rerun them on all RDHPCs?

Copy link
Copy Markdown
Collaborator

@BenjaminBlake-NOAA BenjaminBlake-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clyden-noaa Thanks for testing! No need to re-run the RTs - the most recent commits from Eric added UPP control files for a high resolution fire weather run, which is not currently part of the RTs.

This PR is ready for merging.

@BenjaminBlake-NOAA BenjaminBlake-NOAA merged commit 8020381 into NOAA-EMC:develop May 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Change The baselines of the UPP regression tests are changed. MPAS Ready for commit queue Ready for Review This PR is ready for code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update name of smoke variable in INITPOST_MPAS.F

4 participants