WW3 2dm File Format#1148
Draft
aronroland wants to merge 27 commits into
Draft
Conversation
…ndary for gr3 files
…solver have been forgotten to merge by me. The solver conevergence computation have not been good before due to the choosen accuracies.
Collaborator
|
@aronroland since this is from the ERDC fork, we are expecting regression test information before we start review and testing on this PR. I did notice that you have deleted the ufs1.2 regression test. Was this intentional? I don't see any mention of it in the PR description. |
Collaborator
Author
|
for sure not by purpose i did actually nothing on the regtests ... hmmm strange ....--Sent from my Android phone with GMX Mail. Please excuse my brevity.On 12/19/23, 2:31 PM Jessica Meixner ***@***.***> wrote:
@aronroland since this is from the ERDC fork, we are expecting regression test information before we start review and testing on this PR. I did notice that you have deleted the ufs1.2 regression test. Was this intentional? I don't see any mention of it in the PR description.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Collaborator
|
@aronroland no worries, we'll just want to make sure that regression test is added back before we proceed with this PR. |
…generate boundary conditions ...
…hris and others
Collaborator
|
Converting to draft. Please mark as ready for review after testing information is available. |
Conflicts: model/src/w3wavemd.F90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Add alternative File Format for the use of WW3 by ERDC. This is the native SMS format called *.2dm.
Description
Beside the new format, active boundary and Neuman type boundary conditions can be prescribed in the meshbnd.2dm file. The file name is yet default.
Please also include the following information:
none
new feature
None, but a new regression test was designed. Needs to be discussed.
-->
Issue(s) addressed
none
Commit Message
Add 2dm file format for unstructured grids.
Check list
Will be discussed these days
Testing
In a new regtest based on tp2.6.
Yes, see above.
No
None expected.
Will be done ...