Ww3 homp#1149
Draft
aronroland wants to merge 24 commits into
Draft
Conversation
…solver have been forgotten to merge by me. The solver conevergence computation have not been good before due to the choosen accuracies.
Contributor
|
@aronroland @thesser1 It's really great to see all this new work coming in! Can we expect the testing results soon as well? Please keep us posted on your progress so we know when we can start to review on our end. |
Collaborator
Author
|
yes, sir we do our best |
Contributor
|
Sounds good. Thank you, Aron |
| FLUSH(740+IAPROC) | ||
| #endif | ||
|
|
||
| #ifdef W3_O MPH |
Collaborator
There was a problem hiding this comment.
Hey @aronroland - just spotted this potential typo?
Should this be W3_OMPH, not W3_O MPH?
Or was it deliberate to disable that OMP directive?
Collaborator
|
@aronroland I'm going to mark this as a draft. Please mark it as ready to review when it's time and testing information is available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Hybrid OpenMP for UG
Description
This pull request implements Hybrid OpenMP for UG-Schemes.
Please also include the following information:
new feature
No
Issue(s) addressed
none
Commit Message
OMPH for UGRID
Check list
tp2.6 was tested, certain regtests have to be designed yet.
Testing
tp2.6 war run with various settings
I made a new regression test needs to be added to the suite.
Will do that with ERDC
to be done ...
to be done ...