Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements the campus fund donation page as part of issue #887 by adding a dedicated page that displays donation totals and facilitates teacher selection and report submission. Key changes include:
- A new campus fund page layout with interactive building selection and donation calculations.
- New components for selecting a teacher and submitting donation reports.
- An updated navigation link incorporating the campus fund entry and minor database script adjustments.
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| view/next-project/src/pages/campus_fund/index.tsx | Adds the new campus fund page with donation amount calculation and interactive building selection. |
| view/next-project/src/constants/linkItem.tsx | Updates navigation links to include a dedicated campus fund entry. |
| view/next-project/src/components/campus_fund/SelectTeacherModal.tsx | Implements a modal for teacher selection associated with a building. |
| view/next-project/src/components/campus_fund/ReportModal.tsx | Implements a modal for submitting donation reports. |
| view/next-project/src/components/campus_fund/OpenEditModalButton.tsx | Introduces the button component for opening the donation report modal. |
| view/next-project/package.json | Adds react-datepicker dependency for date selection functionality. |
| mysql/db/19_expenses.sql | Comments out the stored procedure code, preserving legacy code for potential future use. |
| mysql/db/19_expenses.sh | Provides a shell script to create/update the stored procedure for expense processing. |
Files not reviewed (1)
- view/next-project/package-lock.json: Language not supported
Comment on lines
63
to
64
| cursor="pointer" | ||
| onClick={() => handleBuildingClick(building.name)} |
There was a problem hiding this comment.
The GridItem used for building selection is clickable but lacks keyboard accessibility attributes. Consider adding 'role="button"' and 'tabIndex={0}' to ensure it is accessible via keyboard navigation.
Suggested change
| cursor="pointer" | |
| onClick={() => handleBuildingClick(building.name)} | |
| cursor="pointer" | |
| role="button" | |
| tabIndex={0} | |
| onClick={() => handleBuildingClick(building.name)} | |
| onKeyDown={(e) => { | |
| if (e.key === 'Enter' || e.key === ' ') { | |
| e.preventDefault(); | |
| handleBuildingClick(building.name); | |
| } | |
| }} |
| } | ||
|
|
||
| const OpenEditModalButton = (props: Props) => { | ||
| const [showModal, setShowModal] = useState(false); |
There was a problem hiding this comment.
The state variable 'showModal' is set but never used in the component; consider removing it or integrating modal toggling logic if it was intended to control visibility.
Deploying finansu with
|
| Latest commit: |
44013f5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://70770a7c.finansu.pages.dev |
| Branch Preview URL: | https://feat-sato-887-add-fund-page.finansu.pages.dev |
Chikuwa0141
reviewed
May 10, 2025
Collaborator
Chikuwa0141
left a comment
Chikuwa0141
left a comment
There was a problem hiding this comment.
修正箇所をNotionにまとめたので確認お願いします！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #887
概要
募金ページのデザイン実装
データは仮に定義しているもので、APIのPRがmergeされ次第、変更する
画面スクリーンショット等
URLテスト項目
備考