fix: correct bidirectional attention masking in LlamaBidirectionalModel#1349
Open
oliverholworthy wants to merge 1 commit intomainfrom
Open
fix: correct bidirectional attention masking in LlamaBidirectionalModel#1349oliverholworthy wants to merge 1 commit intomainfrom
oliverholworthy wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the biencoder LlamaBidirectionalModel to handle masking correctly with newer transformers versions and different attention implementations.
_update_causal_maskoverride with a proper _create_bidirectional_mask method that produces the correct mask format for each attention backend (SDPA/eager, Flash Attention 2, and the native transformers >= 5.0 path)Changelog
The old _update_causal_mask had two problems:
_update_causal_maskfrom LlamaModel, so our override becomes a dead method that is never called. The model silently falls back to causal masking when using sdpa or eager attn_implementationThe new
_create_bidirectional_maskmethod:create_bidirectional_maskfromtransformers.masking_utilswhen available (transformers >= 5.0), which handles all backends natively.Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information