Set materialize_only_last_token_logits=False when log_probs = True#613
Open
Set materialize_only_last_token_logits=False when log_probs = True#613
Conversation
Signed-off-by: Abhishree <abhishreetm@gmail.com>
Contributor
Author
|
/ok to test a887964 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCore's DynamicInferenceEngine introduces
materialize_only_last_token_logitsinInferenceConfigwith a default value ofTrueto avoid computing logprobs for all tokens (prompt + completion) to save memory and optimize performance. By default in deployment, when the dynamic engine is built from the static engine it builds aDynamicInferenceContextwith anInferenceConfig(...)that has the default value ofTrueformaterialize_only_last_token_logits.This raises an error while evaluating the benchmarks that requires logprobs:
As a fix this PR sets
materialize_only_last_token_logitstoFalsewhenlogprobs = Truewhich is the case for logrob benchmarks.