Skip to content

Comments

pypi compatibility#649

Open
cmunley1 wants to merge 22 commits intomainfrom
cmunley1/pypi-compat
Open

pypi compatibility#649
cmunley1 wants to merge 22 commits intomainfrom
cmunley1/pypi-compat

Conversation

@cmunley1
Copy link
Contributor

@cmunley1 cmunley1 commented Feb 5, 2026

  • search cwd for env.yaml and for config paths provided to ng_run.
  • use importlib.metadata for ng_help
  • modify server requirements.txt or pyproject.toml to use pypi nemo-gym rather than ../../ relative path

basic tests done of ng_run and ng_collect_rollouts with an environment outside of Gym/.

I think that we should really consider a few things, but maybe we stick to minimal changes for now:

  • packaging environments separately
  • moving resources_servers etc inside nemo_gym to have only 1 entrypoint in sitepackages, i find it strange to have site-packages/resources_servers
  • giving user clear guidance on proper way to make new env with pip installed gym. Mocking Gym repo structure is 1 option

@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 5, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
@cmunley1 cmunley1 requested a review from chtruong814 February 10, 2026 02:12
@cmunley1
Copy link
Contributor Author

to test:
uv pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ nemo-gym==0.2.9172rc0 , create local resources server (just copy paste one out of Gym and change name), and run rollouts.

Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Signed-off-by: cmunley1 <cmunley@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 19, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: cmunley1 <cmunley@nvidia.com>
Signed-off-by: cmunley1 <cmunley@nvidia.com>
Signed-off-by: cmunley1 <cmunley@nvidia.com>
Signed-off-by: cmunley1 <cmunley@nvidia.com>
Signed-off-by: cmunley1 <cmunley@nvidia.com>
Signed-off-by: cmunley1 <cmunley@nvidia.com>
Signed-off-by: cmunley1 <cmunley@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant