Add redirection to log stdout and stderr files per server#661
Open
ananthsub wants to merge 5 commits intoNVIDIA-NeMo:mainfrom
Open
Add redirection to log stdout and stderr files per server#661ananthsub wants to merge 5 commits intoNVIDIA-NeMo:mainfrom
ananthsub wants to merge 5 commits intoNVIDIA-NeMo:mainfrom
Conversation
ananthsub
force-pushed
the
add-logs-timing
branch
from
dde45ed to
4204adc
Compare
ananthsub
changed the title
ananthsub
commented
Feb 11, 2026
| def start(self, global_config_dict_parser_config: GlobalConfigDictParserConfig) -> None: | ||
| global_config_dict = get_global_config_dict(global_config_dict_parser_config=global_config_dict_parser_config) | ||
|
|
||
| self._log_dir = Path(global_config_dict.get(SERVER_LOG_DIR_KEY_NAME, str(RESULTS_DIR / "logs"))) |
Contributor
Author
There was a problem hiding this comment.
rfc: this makes the log redirection by default enabled rather than opt-in
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
force-pushed
the
add-logs-timing
branch
from
7b56cbb to
a02e41f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds redirection for each server's stdout/stderr to per-server log files under
{log_dir}/{server_name}/so that output is preserved and isolated per server.poll()tails the last lines of both stderr and stdout streams inline to surface potential issues quickly.RESULT_DIR/logs/. To customize, users can setserver_log_dirin the config YAML or override it via CLI