feat: per task chat template and extra body args#672
Open
Conversation
Signed-off-by: Christian Munley <cmunley@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
bxyu-nvidia
requested changes
Feb 11, 2026
| if body_dict.get("metadata") and isinstance(body_dict["metadata"], dict): | ||
| metadata_chat_kwargs_str = body_dict["metadata"].get("chat_template_kwargs") | ||
| if metadata_chat_kwargs_str: | ||
| try: |
Contributor
There was a problem hiding this comment.
can we take out the try except here and fail loudly when we cannot decode properly pls?
| chat_template_kwargs = deepcopy(self.config.chat_template_kwargs) | ||
|
|
||
| # Merge global config chat_template_kwargs with per-request overrides in metadata (e.g. per-sample reasoning on/off) | ||
| if body_dict.get("metadata") and isinstance(body_dict["metadata"], dict): |
Contributor
There was a problem hiding this comment.
can we apply to both chat template kwargs and extra_body?
Signed-off-by: Christian Munley <cmunley@nvidia.com>
Contributor
Author
|
tested extra body, is working with thinking budget |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support different chat template kwargs and extra body params per task, such as reasoning on/off or thinking budget.
see #619
I have not tested extra body outside of the new tests (tho I hope to with thinking budget). Only tested chat template enable thinking on/off with single-step no tool environment. We should test in training and with tools.
this allows adding to tasks in dataset:
or true.
then we get results like:
or