Skip to content

Comments

build: Update dockerfile to support Nsight install on arm platforms#1939

Open
ananthsub wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
ananthsub:arm-container-nsys
Open

build: Update dockerfile to support Nsight install on arm platforms#1939
ananthsub wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
ananthsub:arm-container-nsys

Conversation

@ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Feb 12, 2026

What does this PR do ?

Update dockerfile to support Nsight install on arm platforms

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated Docker build process to support multiple processor architectures, enabling image builds on ARM-based and other non-x86_64 systems.

@ananthsub ananthsub requested a review from a team as a code owner February 12, 2026 22:01
@ananthsub ananthsub changed the title docker: Update dockerfile to support Nsight install on arm platforms build: Update dockerfile to support Nsight install on arm platforms Feb 12, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Walkthrough

The Dockerfile's Nvidia apt key fetch URL was modified to dynamically derive the system architecture at build time using $(uname -m | sed 's/aarch64/sbsa/') instead of a hardcoded x86_64 path, enabling multi-architecture support.

Changes

Cohort / File(s) Summary
Docker Build Configuration
docker/Dockerfile
Modified Nvidia apt key URL to use dynamic architecture detection at build time instead of static x86_64 path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (28 files):

⚔️ .github/workflows/cicd-main.yml (content)
⚔️ docker/Dockerfile (content)
⚔️ examples/configs/distillation_math.yaml (content)
⚔️ examples/configs/distillation_math_megatron.yaml (content)
⚔️ examples/configs/dpo.yaml (content)
⚔️ examples/configs/grpo_math_1B.yaml (content)
⚔️ examples/configs/recipes/llm/grpo-llama3.1-8b-instruct-2n8g-megatron-fp8-e2e.yaml (content)
⚔️ examples/configs/recipes/llm/grpo-moonlight-16ba3b-4n8g-megatron-fp8-e2e.yaml (content)
⚔️ examples/configs/recipes/llm/performance/grpo-llama3.1-8b-instruct-2n8g-fp8-async-1off.yaml (content)
⚔️ examples/configs/rm.yaml (content)
⚔️ examples/configs/sft.yaml (content)
⚔️ examples/configs/sft_openmathinstruct2_megatron.yaml (content)
⚔️ examples/configs/vlm_grpo_3B.yaml (content)
⚔️ examples/configs/vlm_grpo_3B_megatron.yaml (content)
⚔️ nemo_rl/algorithms/grpo.py (content)
⚔️ nemo_rl/environments/utils.py (content)
⚔️ nemo_rl/models/megatron/data.py (content)
⚔️ nemo_rl/models/policy/workers/megatron_policy_worker.py (content)
⚔️ pyproject.toml (content)
⚔️ research/template_project/configs/grpo_math_1B.yaml (content)
⚔️ tests/functional/L1_Functional_Tests_GPU.sh (content)
⚔️ tests/functional/dpo_megatron.sh (content)
⚔️ tests/unit/L0_Unit_Tests_Generation.sh (content)
⚔️ tests/unit/L0_Unit_Tests_Other.sh (content)
⚔️ tests/unit/L0_Unit_Tests_Policy.sh (content)
⚔️ tests/unit/models/megatron/test_megatron_data.py (content)
⚔️ tests/unit/test_recipes_and_test_suites.py (content)
⚔️ uv.lock (content)

These conflicts must be resolved before merging into main.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the Dockerfile to support Nsight installation on ARM platforms by using dynamic architecture detection instead of a hardcoded x86_64 path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed The PR contains only a minor single-line Dockerfile modification for ARM platform support, which satisfies the pass condition.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
⚔️ Resolve merge conflicts (beta)
  • Auto-commit resolved conflicts to branch arm-container-nsys
  • Post resolved changes as copyable diffs in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
@guyueh1 guyueh1 added the CI:L2 Run doctests, unit tests, functional tests, and convergence tests label Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L2 Run doctests, unit tests, functional tests, and convergence tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants