Skip to content

Comments

chore: Switch to mcore upstream main#1990

Draft
ahmadki wants to merge 3 commits intomainfrom
ahmadki/mcore_main
Draft

chore: Switch to mcore upstream main#1990
ahmadki wants to merge 3 commits intomainfrom
ahmadki/mcore_main

Conversation

@ahmadki
Copy link
Member

@ahmadki ahmadki commented Feb 19, 2026

What does this PR do ?

The PR replaces the mcore fork created for RL with upstream version

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@ahmadki ahmadki changed the title Switch to mcore upstream main feat: Switch to mcore upstream main Feb 19, 2026
@github-actions
Copy link

❌ Submodule Fast-Forward Check Failed

Check based on commit: e5d1ae9 (PR #1990 from ahmadki/mcore_main)

❌ Submodules that need attention:

Megatron-LM: ❌ Commits have DIVERGED from a common ancestor
TARGET (main branch): https://github.com/NVIDIA/Megatron-LM/commits/193463c4f8414e6906a40dd527a450bca50706b1/
CURRENT (PR #1990 from ahmadki/mcore_main): https://github.com/NVIDIA/Megatron-LM/commits/0d0943c6bfa9cbb30fcd62d40ce1792c4cb201e8/

Please ensure all submodule commits are fast-forwards of the main branch before merging.

@ahmadki ahmadki added the CI:L2 Run doctests, unit tests, functional tests, and convergence tests label Feb 19, 2026
Signed-off-by: Ahmad Kiswani <kiswani.ahmad@gmail.com>
@ahmadki ahmadki changed the title feat: Switch to mcore upstream main chore: Switch to mcore upstream main Feb 20, 2026
@github-actions
Copy link

❌ Submodule Fast-Forward Check Failed

Check based on commit: c19ee75 (PR #1990 from ahmadki/mcore_main)

❌ Submodules that need attention:

Megatron-LM: ❌ Commits have DIVERGED from a common ancestor
TARGET (main branch): https://github.com/NVIDIA/Megatron-LM/commits/b12071b947f9ee3c6616306662069fc4ca77be4c/
CURRENT (PR #1990 from ahmadki/mcore_main): https://github.com/NVIDIA/Megatron-LM/commits/0d0943c6bfa9cbb30fcd62d40ce1792c4cb201e8/

Please ensure all submodule commits are fast-forwards of the main branch before merging.

@github-actions
Copy link

❌ Submodule Fast-Forward Check Failed

Check based on commit: 891b3c2 (PR #1990 from ahmadki/mcore_main)

❌ Submodules that need attention:

Megatron-LM: ❌ Commits have DIVERGED from a common ancestor
TARGET (main branch): https://github.com/NVIDIA/Megatron-LM/commits/b12071b947f9ee3c6616306662069fc4ca77be4c/
CURRENT (PR #1990 from ahmadki/mcore_main): https://github.com/NVIDIA/Megatron-LM/commits/0d0943c6bfa9cbb30fcd62d40ce1792c4cb201e8/

Please ensure all submodule commits are fast-forwards of the main branch before merging.

@ahmadki ahmadki added CI:L2 Run doctests, unit tests, functional tests, and convergence tests and removed CI:L2 Run doctests, unit tests, functional tests, and convergence tests labels Feb 20, 2026
@github-actions
Copy link

❌ Submodule Fast-Forward Check Failed

Check based on commit: 6674072 (PR #1990 from ahmadki/mcore_main)

❌ Submodules that need attention:

Megatron-LM: ❌ Commits have DIVERGED from a common ancestor
TARGET (main branch): https://github.com/NVIDIA/Megatron-LM/commits/b12071b947f9ee3c6616306662069fc4ca77be4c/
CURRENT (PR #1990 from ahmadki/mcore_main): https://github.com/NVIDIA/Megatron-LM/commits/0d0943c6bfa9cbb30fcd62d40ce1792c4cb201e8/

Please ensure all submodule commits are fast-forwards of the main branch before merging.

@ahmadki ahmadki added CI:L2 Run doctests, unit tests, functional tests, and convergence tests and removed CI:L2 Run doctests, unit tests, functional tests, and convergence tests labels Feb 22, 2026
Signed-off-by: Ahmad Kiswani <kiswani.ahmad@gmail.com>
@github-actions
Copy link

❌ Submodule Fast-Forward Check Failed

Check based on commit: 924e32a (PR #1990 from ahmadki/mcore_main)

❌ Submodules that need attention:

Megatron-LM: ❌ Commits have DIVERGED from a common ancestor
TARGET (main branch): https://github.com/NVIDIA/Megatron-LM/commits/b12071b947f9ee3c6616306662069fc4ca77be4c/
CURRENT (PR #1990 from ahmadki/mcore_main): https://github.com/NVIDIA/Megatron-LM/commits/0d0943c6bfa9cbb30fcd62d40ce1792c4cb201e8/

Please ensure all submodule commits are fast-forwards of the main branch before merging.

@ahmadki ahmadki added CI:L2 Run doctests, unit tests, functional tests, and convergence tests and removed CI:L2 Run doctests, unit tests, functional tests, and convergence tests labels Feb 22, 2026
Signed-off-by: Ahmad Kiswani <kiswani.ahmad@gmail.com>
@ahmadki ahmadki added CI:L2 Run doctests, unit tests, functional tests, and convergence tests and removed CI:L2 Run doctests, unit tests, functional tests, and convergence tests labels Feb 22, 2026
@github-actions
Copy link

❌ Submodule Fast-Forward Check Failed

Check based on commit: 4ba7f09 (PR #1990 from ahmadki/mcore_main)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

❌ Submodules that need attention:

Megatron-LM: ❌ Commits have DIVERGED from a common ancestor
TARGET (main branch): https://github.com/NVIDIA/Megatron-LM/commits/b12071b947f9ee3c6616306662069fc4ca77be4c/
CURRENT (PR #1990 from ahmadki/mcore_main): https://github.com/NVIDIA/Megatron-LM/commits/0d0943c6bfa9cbb30fcd62d40ce1792c4cb201e8/

Please ensure all submodule commits are fast-forwards of the main branch before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L2 Run doctests, unit tests, functional tests, and convergence tests Run CICD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant