Skip to content

Conversation

@wujingyue
Copy link
Collaborator

E[22:55:14.740] tidy-config error at /opt/pytorch/nvfuser/.clang-tidy:50:0: unknown key 'AnalyzeTemporaryDtors'

```
E[22:55:14.740] tidy-config error at /opt/pytorch/nvfuser/.clang-tidy:50:0: unknown key 'AnalyzeTemporaryDtors'
```
@wujingyue wujingyue requested a review from xwang233 February 3, 2026 07:21
@wujingyue
Copy link
Collaborator Author

!build

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Description

  • Remove deprecated AnalyzeTemporaryDtors configuration line from .clang-tidy

  • Fix tidy-config error: unknown key 'AnalyzeTemporaryDtors'

  • Clean up invalid clang-tidy configuration option

Changes walkthrough

Relevant files
Bug fix
.clang-tidy
Remove deprecated AnalyzeTemporaryDtors config                     

.clang-tidy

  • Removed the deprecated 'AnalyzeTemporaryDtors: false' configuration
    line
  • This eliminates the clang-tidy configuration error
  • +0/-1     

    PR Reviewer Guide

    Here are some key observations to aid the review process:

    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @greptile-apps
    Copy link
    Contributor

    greptile-apps bot commented Feb 3, 2026

    Greptile Overview

    Greptile Summary

    This PR removes the deprecated AnalyzeTemporaryDtors configuration option from .clang-tidy that was causing configuration errors.

    • Removed AnalyzeTemporaryDtors: false from line 50 of .clang-tidy
    • Fixes the error: unknown key 'AnalyzeTemporaryDtors' reported at startup
    • The AnalyzeTemporaryDtors option was deprecated in newer versions of clang-tidy and is no longer recognized

    Confidence Score: 5/5

    • This PR is completely safe to merge with no risk
    • The change removes a single deprecated configuration option that was causing errors. The removal is straightforward, doesn't affect any code logic, and fixes a known configuration issue.
    • No files require special attention

    Important Files Changed

    Filename Overview
    .clang-tidy Removed deprecated AnalyzeTemporaryDtors configuration option that was causing tidy-config errors

    Sequence Diagram

    sequenceDiagram
        participant Dev as Developer
        participant CT as clang-tidy
        participant Config as .clang-tidy
    
        Dev->>CT: Run clang-tidy
        CT->>Config: Parse configuration file
        Config-->>CT: Contains AnalyzeTemporaryDtors option
        CT-->>Dev: Error: unknown key 'AnalyzeTemporaryDtors'
        
        Note over Dev,Config: After PR #5913
        
        Dev->>CT: Run clang-tidy
        CT->>Config: Parse configuration file
        Config-->>CT: Valid configuration (deprecated option removed)
        CT-->>Dev: Success
    
    Loading

    Copy link
    Contributor

    @greptile-apps greptile-apps bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    1 file reviewed, no comments

    Edit Code Review Agent Settings | Greptile

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant