-
Notifications
You must be signed in to change notification settings - Fork 77
Remove legacy bindings #5917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove legacy bindings #5917
Conversation
|
!test |
|
Review updated until commit 11be6d7 Description
|
| Relevant files | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Enhancement | 5 files
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Documentation | 1 files
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Miscellaneous | 1 files
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Additional files | 34 files
|
PR Reviewer Guide
Here are some key observations to aid the review process:
| 🧪 PR contains tests |
| ⚡ Recommended focus areas for review |
Build System Changes
|
Test failures
-
(Medium, 3)
Thunder thunderfx path returns scalar instead of vector in higher-order inplace alias update (thunder.tests.test_update_aliases)Test Name A100 GB200 H100 Source thunder.tests.test_update_aliases.test_higher_order_inplace_alias_update_nvfuser_cuda_thunder.dtypes.float32 ❌ ❌ ❌ -
(Medium, 3)
ModuleNotFoundError for 'nvfuser' in tests.python.direct.test_importTest Name A100 GB200 H100 Source tests.python.direct.test_import.test_import_conflict_direct_then_nvfuser ❌ ❌ ❌
Greptile OverviewGreptile SummaryThis PR removes the legacy Major changes:
Issues found:
These files need to be updated to import from Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Python
participant nvfuser_direct
participant libnvfuser_codegen
Note over nvfuser: Legacy module REMOVED
User->>Python: import nvfuser_direct
Python->>nvfuser_direct: Load _C_DIRECT extension
nvfuser_direct->>libnvfuser_codegen: Link to shared library
libnvfuser_codegen-->>nvfuser_direct: Core codegen functionality
nvfuser_direct-->>Python: Module loaded
Python-->>User: Success
Note over User,Python: Old workflow (NOW BROKEN):
User->>Python: import nvfuser
Python-->>User: ImportError: No module named 'nvfuser'
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7 files reviewed, 2 comments
Additional Comments (2)
|
|
!build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 files reviewed, 1 comment
Additional Comments (1)
|
7d0a9ba to
904ab90
Compare
|
!test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 files reviewed, 1 comment
|
!test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 7 comments
Additional Comments (7)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
This PR removes the
nvfuserpython module, corresponding pybind11 CPP bindings, and any references fromcsrc. Version is bumped to0.2.36.