Implement packing overflow and grouping#228
Open
voegtlel wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packing Overflow
Returning samples into the packing buffer when running
select_samples_to_pack:Packing Grouping
In the MetadatasetV2, specify
packing_group, all datasets with the same packing group will be packed in the same packing buffer.New flow:
[(blend) → (shuffle) → (select_samples_to_pack) → (postencode) → (pack_selected_samples)](per group) → (blend). If not grouping, this simplifies to(blend) → (shuffle) → (select_samples_to_pack) → (postencode) → (pack_selected_samples).Would create three packing buffers:
Alpha: contains samples from ds1 + ds2Beta: Only contains samples from ds3None(=default): Contains samples from ds4To configure the buffer sizes:
This would mean: Alpha has a packing buffer size of 100. Beta does not do packing. Default would have pbs=10. Same for shuffle buffer sizes.